Rename SwiftStdlibCurrentOS to StdlibDeploymentTarget. #81940
Conversation
al45tair
requested review from
ktoso,
a team,
etcwilde,
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci Please smoke test |
| # will expand to the current `-target` platform if the macro defines a | ||
| # newer platform as its availability. | ||
| # | ||
| # There is a setting, SWIFT_STDLIB_ENABLE_STRICT_AVAILABILITY, which if set | ||
| # ON will cause us to use the "proper" availability instead. | ||
| string(REPLACE "SwiftStdlib" "SwiftStdlibCurrentOS" current "${def}") | ||
| string(REPLACE "SwiftStdlib" "DeploymentTarget" current "${def}") |
There was a problem hiding this comment.
I am afraid the new name as is could become a little difficult to search in the code base (as the compiler code already use DeploymentTarget for a few symbols) -- filters could help (e.g. files under stdlib, or files ending with *.cmake), but I personally don't always add those (especially when I'm doing a quick search to assess issues).
| string(REPLACE "SwiftStdlib" "DeploymentTarget" current "${def}") | |
| string(REPLACE "SwiftStdlib" "SwiftStdlibDeploymentTarget" current "${def}") |
If adding back a prefix is not desirable, I would suggest to document this choice in utils/availability-macros.def
There was a problem hiding this comment.
I'm not sure this is such a problem in practice as you could always do a regex search for DeploymentTarget \d+\.\d+.
What do you think, @stephentyrone? Happy to change the name if we think it's worth doing.
There was a problem hiding this comment.
Decided on reflection to change it to StdlibDeploymentTarget. I don't want to make it too long, but I think @edymtt is right that it's easier if it's a unique string (there are some hits in some of the Python code for StdlibDeploymentTarget, but I don't think that's particularly troublesome, and adding Swift as well just makes it really long).
`StdlibDeploymentTarget` seems to be a better name. rdar://152498657
al45tair
force-pushed
the
eng/PR-152498657
branch
from
be65e53 to
42ca1b1
Compare
al45tair
changed the title
|
@swift-ci Please smoke test |
StdlibDeploymentTargetseems to be a better name.rdar://152498657