[Indexing] Don't verify mangling of USRs #81941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
dont-verify-mangle
branch
from
3d628b3 to
ca2060f
Compare
|
@swift-ci Please smoke test |
hamishknight
reviewed
Jun 3, 2025
Seems like a bug with the Observation module's dependencies (cc: @phausler) |
slavapestov
reviewed
Jun 3, 2025
lib/AST/ASTMangler.cpp
Outdated
| verify(Storage.str(), Flavor); | ||
| return finalize(); | ||
| } | ||
|
|
||
| std::string ASTMangler::mangleDeclAsUSR(const ValueDecl *Decl, | ||
| StringRef USRPrefix) { | ||
| return (llvm::Twine(USRPrefix) + mangleAnyDecl(Decl, false)).str(); | ||
| #ifndef NDEBUG |
There was a problem hiding this comment.
Instead of NDEBUG can you check if (CONDITIONAL_ASSERT_enabled())?
There was a problem hiding this comment.
Great idea. Thanks, Slava.
|
@swift-ci please test Windows platform |
ahoppen
force-pushed
the
dont-verify-mangle
branch
from
ca2060f to
ef95fda
Compare
|
@swift-ci Please smoke test |
bnbarham
reviewed
Jun 4, 2025
Verifying USR mangling adds ~30% overhead to indexing times. Since an incorrect USR mangling doesn't result in a correctness issue at the same level as a miscompile, save those 30% in non-assert builds.
ahoppen
force-pushed
the
dont-verify-mangle
branch
from
ef95fda to
563f971
Compare
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Jun 4, 2025
bnbarham
approved these changes
Jun 4, 2025
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying USR mangling adds ~30% overhead to indexing times. Since an incorrect USR mangling doesn't result in a correctness issue at the same level as a miscompile, save those 30% in non-assert builds.