[AST] Remove getSemanticAttrs
#81942
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After swiftlang#69578, the only users of `getSemanticAttrs` after that PR are the AST printer and `SemaAnnotator`, all other calls were switched to `getExpandedAttrs`. This caused the `SemanticDeclAttrsRequest` to only get evaluated during indexing, which ends up doing semantic analysis in the pass that writes out the index data. Neither the AST printer nor indexing should report data that is unavailable during compilation and so both of these should use `getExpandedAttrs`.
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #69578, the only users of
getSemanticAttrsafter that PR are the AST printer andSemaAnnotator, all other calls were switched togetExpandedAttrs. This caused theSemanticDeclAttrsRequestto only get evaluated during indexing, which ends up doing semantic analysis in the pass that writes out the index data. Neither the AST printer nor indexing should report data that is unavailable during compilation and so both of these should usegetExpandedAttrs.