[cxx-interop] Support Swiftifying C++ constructors #81947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
hnrklssn
reviewed
Jun 3, 2025
j-hui
reviewed
Jun 4, 2025
Unfortunately, there is no common abstraction for initializers and functions in SwiftSyntax, so this PR rolls our own. Alternatively, we could probably achieve something similar with a new protocol, but we only needed a handful of fields so this change keeps it simple. rdar://152112660
Xazax-hun
force-pushed
the
gaborh/swiftify-initializers
branch
from
17eeff2 to
d5fadda
Compare
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there is no common abstraction for initializers and functions in SwiftSyntax, so this PR rolls our own. Alternatively, we could probably achieve something similar with a new protocol, but we only needed a handful of fields so this change keeps it simple.
rdar://152112660