Sema: Implement missing part of SE-0346 #81949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
missing-part-of-se-0346
branch
from
a27fa64 to
2183880
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
xedin
approved these changes
Jun 3, 2025
AnthonyLatsis
approved these changes
Jun 3, 2025
Comment on lines
+1797
to
+1801
| } else if (auto *pct = inheritedTy->getAs<ProtocolCompositionType>()) { | ||
| for (auto member : pct->getMembers()) { | ||
| collectProtocolsFromInheritedEntry(entry, member, | ||
| protocolsWithRetroactiveAttr, protos); | ||
| } |
There was a problem hiding this comment.
Do we have a test case for a nested composition?
slavapestov
force-pushed
the
missing-part-of-se-0346
branch
from
2183880 to
235db43
Compare
|
@AnthonyLatsis it would crash on ambiguity. I added a little bit of logic that makes us now diagnose an ambiguity error. |
slavapestov
force-pushed
the
missing-part-of-se-0346
branch
from
235db43 to
28575b0
Compare
The proposal states that this should work, but this was never
implemented:
protocol P<A> {
associatedtype A
}
struct S: P<Int> {}
- Fixes swiftlang#62906.
- Fixes rdar://91842338.
…oseRetroactiveConformances()
slavapestov
force-pushed
the
missing-part-of-se-0346
branch
from
28575b0 to
185a91d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal states that this should work, but this was never implemented: