[DestroyAddrHoisting] Skip init_enum_data_addrs. #81952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar152431332
branch
from
0b2c05c to
0df5b51
Compare
moveonlywrapper_to_copyable_box changes the type so it's a type cast not an identity cast.
The new function stripAccessAndAccessStorageCasts is analogous to the existing function stripAccessAndIdentityCasts but differs in that the latter uses isAccessStorageIdentityCast whereas the new function uses isAccessStorageCast.
A destroy of an `init_enum_data_addr` is not equivalent to a destroy of the whole enum's address. Treat such destroys just like destroys of `struct_element_addr`s are treated: by bailing out. rdar://152431332
nate-chandler
force-pushed
the
rdar152431332
branch
from
0df5b51 to
c41fd47
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please smoke test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A destroy of an
init_enum_data_addris not equivalent to a destroy of the whole enum's address. Treat such destroys just like destroys ofstruct_element_addrs are treated: by bailing out.rdar://152431332