[cmake] add SINGLE_THREADED_MODE option to Synchronization #81980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justice-adams-apple
requested review from
etcwilde,
compnerd and
edymtt
as code owners
|
@swift-ci smoke test |
compnerd
reviewed
Jun 4, 2025
| @@ -58,6 +58,8 @@ option(${PROJECT_NAME}_ENABLE_LIBRARY_EVOLUTION "Generate ABI resilient runtime | |||
| option(${PROJECT_NAME}_ENABLE_PRESPECIALIZATION "Enable generic metadata prespecialization" | |||
| ${SwiftCore_ENABLE_PRESPECIALIZATION}) | |||
|
|
|||
| option(${PROJECT_NAME}_FORCE_EMPTY_MUTEX_IMPLEMENTATION "Force use an empty mutex implementation" OFF) | |||
There was a problem hiding this comment.
Why _FORCE? Why not call this Synchronization_SINGLE_THREADED_MODE?
There was a problem hiding this comment.
@compnerd renamed the variable
justice-adams-apple
force-pushed
the
jadams/force-empty-mutex
branch
from
6bcd886 to
5dd300d
Compare
|
@swift-ci smoke test |
justice-adams-apple
changed the title
edymtt
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SwiftSynchronization_FORCE_EMPTY_MUTEX_IMPLEMENTATIONflag to use empty mutex definition for certain apple platforms. This brings Synchronization in line with the current build systems functionalityWe will revisit this in the future to determine if we can add a mutex definition for all Darwin platforms