[6.2] utils: Add llvm-symbolizer to install_components_with_clang presets #82007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airspeedswift
approved these changes
Jun 5, 2025
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
3 similar comments
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS platform |
|
Is there something to do to this branch to get the CI happy enough to back port? Is adding this extra tool breaking some build time constraint? |
|
@swift-ci please test macOS platform |
|
@ADKaster can you rebase against the 6.2 branch just to see if that fixes it? |
llvm-symbolizer is critical to ASAN/LSAN properly reading and applying allowlists and suppressions. Without properly symbolized backtraces, the tools cannot match stack traces to suppression lists, leading to false negatives in leak detection and other issues. Ensure that it's installed in the toolchain presets.
auto-merge was automatically disabled
June 16, 2025 16:19
Head branch was pushed to by a user without write access
ADKaster
force-pushed
the
backport-llvm-symbolizer-base-toolchain
branch
from
4cd1d96 to
78f9dc6
Compare
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm-symbolizer is critical to ASAN/LSAN properly reading and applying allowlists and suppressions. Without properly symbolized backtraces, the tools cannot match stack traces to suppression lists, leading to false negatives in leak detection and other issues.
Ensure that it's installed in the toolchain presets.
Extra llvm tool is added. Small increase in bundle size for swift.org toolchains.
Resolves swiftlang/swiftly#368
#81966
Very low. An extra llvm tool will be installed in macOS and Linux toolchain bundles
N/A
@shahmishal @FranzBusch