[cxx-interop] Avoid swiftifying private and protected methods #82016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
hnrklssn
reviewed
Jun 5, 2025
test/Interop/Cxx/class/access/swiftify-private-fileid-executable.swift
Outdated
Show resolved
Hide resolved
The generated overloads do not get seralized and later on the compiler crashes due to the missing body of the SILFunction. This PR works this problem around by not generating these overloads. We plan to address the serialization issue later. rdar://152181531
Xazax-hun
force-pushed
the
gaborh/swiftify-private
branch
from
ed1fe30 to
6eb7057
Compare
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jun 6, 2025
Xazax-hun
added a commit
that referenced
this pull request
Jun 9, 2025
Explanation: We do not serialize the private macro generated swift method's bodies which crashes the compiler. This PR skips generating swiftified overloads to these private/protected method to work around the crash. Issue: rdar://152181531 Risk: Low, the change is straightforward. Testing: Regression test added. Original PR: #82016 Reviewer: @hnrklssn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated overloads do not get seralized and later on the compiler crashes due to the missing body of the SILFunction. This PR works this problem around by not generating these overloads. We plan to address the serialization issue later.
rdar://152181531