[Build] Fix the minimal-stdlib build by setting a deployment version. #82018
Conversation
We need to set a deployment version, not just blank, because otherwise we don't know the correct deployment target to use for the standard library.
al45tair
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
|
@swift-ci Please test |
| @@ -67,6 +67,8 @@ def build(self, host_target): | |||
| self.cmake_options.define( | |||
| 'SWIFT_FREESTANDING_MODULE_NAME:STRING', 'macos') | |||
| self.cmake_options.define('SWIFT_FREESTANDING_SDK:STRING', 'macosx') | |||
| self.cmake_options.define('SWIFT_FREESTANDING_DEPLOYMENT_VERSION:STRING', | |||
There was a problem hiding this comment.
Should we plumb through a flag to override this value? Does 11.0 make sense as the only value for all situations where this is used?
There was a problem hiding this comment.
The 11.0 matches the SWIFT_FREESTANDING_TRIPLE_NAME immediately below, which also doesn't have any extra plumbing. I don't think we need to have a way to override this — my understanding is that the minimal stdlib build is really there for testing purposes, and people actually using it would likely build it or something based on it "by hand" with whatever arguments they actually need.
|
@swift-ci Please smoke test Linux platform |
|
Linux build timed-out on a test. |
|
Force merging to unblock macOS PR testing at least (Linux is an unrelated failure that's also being fixed). These are macOS only changes anyway and can't possibly impact Linux. |
We need to set a deployment version, not just blank, because otherwise we don't know the correct deployment target to use for the standard library.