-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Demangle] Implement missing `Node::Kind::OutlinedInitializeWithTakeN… #82034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please build toolchain macOS platform |
@eeckstein I couldn't come up with a reduction for this based on swift-testing failure in swiftlang/swift-testing#1136 It should be something like this:
But that generates |
…oValueWitness` Implements de/remangler support for `WOB` manglings.
@swift-ci please build toolchain macOS platform |
slavapestov
approved these changes
Jun 5, 2025
@swift-ci please build toolchain macOS platform |
@swift-ci please test |
stmontgomery
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Jun 6, 2025
This applies a workaround to fix macOS builds (including CI) which began failing due to a Swift compiler regression which is expected to be resolved by swiftlang/swift#82034. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
2 tasks
stmontgomery
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Jun 25, 2025
…tory perf optimization pass (#1172) This reverts most of the workaround I landed in #1139. A compiler fix in swiftlang/swift#82034 has resolved the problem that necessitated it, and our macOS CI is using a new-enough toolchain which has that fix. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oValueWitness`
Implements de/remangler support for
WOB
manglings.