[6.2][Concurrency] Downgrade errors to warnings when Sendable requirement is inferred from a preconcurrency protocol #82037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e24196e)
…econcurrencyProtocol` The new name better reflects the intention for this Sendable check kind. (cherry picked from commit 7cca722)
…t is inferred from a preconcurrency protocol If a type gets `Sendable` conformace requirement through another `@preconcurrency` protocol the error should be downgraded even with strict concurrency checking to allow clients time to address the new requirement. Resolves: rdar://146027395 (cherry picked from commit 6d45229)
…appears inside of a member type (cherry picked from commit 3495c61)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #81960
Explanation:
If a type gets
Sendableconformance requirement through another@preconcurrencyprotocol the error should be downgraded evenwith strict concurrency checking to allow clients time to address
the new requirement.
Resolves: rdar://146027395
Main Branch PR: [Concurrency] Downgrade errors to warnings when
Sendablerequirement is inferred from a preconcurrency protocol #81960Risk: Low. Downgrades some errors to warnings and allows more code to type-check successfully.
Reviewed By: @hborla @ktoso
Testing: Added new test-cases to the test suite.