[NFC] Silence some unused variable warnings #82042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang complains that paramIndicesLength is unused. This block is already guarded by CONDITIONAL_ASSERT_enabled(), so promoting assert() to ASSERT() should not affect the behavior of assertions-disabled builds.
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
meg-gupta
reviewed
Jun 12, 2025
|
These changes LGTM, thank you for fixing them! |
Comments in PR swiftlang#80438, where this code comes from, already suggest using ASSERT() instead of assert().
|
@swift-ci please smoke test |
@meg-gupta for super minor changes to assertions like this, do we need to cherry-pick it? |
|
@j-hui I don't think it's necessary to cherry pick this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses some warnings that come from variables that seem unused outside of recently-added
assert()statements. Those warnings come from header files that are used by many translation units. This patch replaces them withASSERT()to "use" the variables.