ClangImporter: import SwiftShims properly for static linking #82065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building against the static standard library, we should define `SWIFT_STATIC_STDLIB` to indicate to the shims that the declarations should be giving hidden visibility and default DLL storage. This is required to ensure that these symbols are known to be `dso_local` when compiling to avoid an unnecessary look up through the PLT/GOT or the indirection through the synthesized `__imp_` symbol and the IAT. This corrects a number of incorrect code generation cases on Windows with the static standard library.
compnerd
requested review from
artemcm,
tshortli,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
DougGregor
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building against the static standard library, we should define
SWIFT_STATIC_STDLIBto indicate to the shims that the declarations should be giving hidden visibility and default DLL storage. This is required to ensure that these symbols are known to bedso_localwhen compiling to avoid an unnecessary look up through the PLT/GOT or the indirection through the synthesized__imp_symbol and the IAT. This corrects a number of incorrect code generation cases on Windows with the static standard library.