[ClangImporter] SE-0463: Implement @Sendable inference exception for global actor isolated functions
#82085
+206
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter This lifts the check for the feature flag up into the `importParameterType` from `importType` and means that completion handler type for `async` variant is no longer gains `@Sendable` attribute.
xedin
requested review from
jckarter,
ktoso,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
ktoso
approved these changes
Jun 7, 2025
|
@swift-ci please test |
…r global actor isolated functions Functions that are isolated to a global actor don't have completion handlers imported as `@Sendable`. Main actor isolated functions with completion handlers that are always called on the main actor is a very common Objective-C pattern, and this carve out will eliminate false positive warnings in the cases where the main actor annotation is missing on the completion handler parameter. Resolves: rdar://149811049
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
1 similar comment
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
4 similar comments
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that are isolated to a global actor don't have completion
handlers imported as
@Sendable. Main actor isolated functions withcompletion handlers that are always called on the main actor is a
very common Objective-C pattern, and this carve out will eliminate
false positive warnings in the cases where the main actor annotation
is missing on the completion handler parameter.
Resolves: rdar://149811049