[6.2][Diagnostics] Correctly diagnose situations when immutable value is passed to inout parameter
#82114
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uting a callee This element is used purely for diagnostic purposes and locator should behavior as if it's completely transparent. (cherry picked from commit 622475b)
…assed to `inout` parameter Currently the note is going to point to the "callee" but that is incorrect when the failure is related to an argument of a call. Detect this situation in `RValueTreatedAsLValueFailure::diagnoseAsNote` and produce a correct note. Resolves: rdar://150689994 (cherry picked from commit 6bbc101)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82053
Explanation:
Currently the note is going to point to the "callee" but that is
incorrect when the failure is related to an argument of a call.
Detect this situation in
RValueTreatedAsLValueFailure::diagnoseAsNoteand produce a correct note.
Resolves: rdar://150689994
Main Branch PR: [Diagnostics] Correctly diagnose situations when immutable value is passed to
inoutparameter #82053Risk: Very Low. This is a diagnostic change.
Reviewed By: @bnbarham
Testing: Added new test-cases to the test suite.