Fix RequirementMachine crash with invalid AST via getSuperclassForDecl() #82115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
approved these changes
Jun 9, 2025
This can return ErrorType if the AST is invalid. A handful of callers handle the ErrorType result, but most don't, blindly assuming the result is always a nominal type. This resulted in a crash in at least one test case. Lift the burden from callers by always returning a nominal type here.
slavapestov
force-pushed
the
get-superclass-for-decl
branch
from
1f61c43 to
7bbb299
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSuperclassForDecl() can return ErrorType if the AST is invalid.
A handful of callers handle the ErrorType result, but most don't, blindly assuming the result is always a nominal type. This resulted in a crash in at least one test case.
Lift the burden from callers by always returning a nominal type here, and instead just filling in the generic arguments with ErrorType in the invalid case.