Skip to content

build-script: Remove support for legacy way of building compiler-rt #82124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

build-script: Remove support for legacy way of building compiler-rt #82124

merged 1 commit into from
Jun 16, 2025

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jun 9, 2025

Addresses rdar://149293315

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented Jun 9, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt
Copy link
Contributor Author

edymtt commented Jun 11, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 11, 2025

Amazon Linux 2 is failing because I forgot to update some tests

[2025-06-09T23:38:30.584Z] Failed Tests (3):
[2025-06-09T23:38:30.584Z]   Swift-validation(linux-x86_64) :: BuildSystem/llvm-build-compiler-rt-on-linux.test
[2025-06-09T23:38:30.584Z]   Swift-validation(linux-x86_64) :: BuildSystem/llvm-build-compiler-rt-with-enable-external-compiler-rt.test
[2025-06-09T23:38:30.584Z]   Swift-validation(linux-x86_64) :: BuildSystem/llvm-build-compiler-rt-with-use-runtimes.test

@edymtt edymtt force-pushed the edymtt/remove-old-way-of-building-compiler-rt branch from c12da77 to 8b7eda3 Compare June 11, 2025 19:20
@edymtt
Copy link
Contributor Author

edymtt commented Jun 11, 2025

@swift-ci please test

@edymtt edymtt force-pushed the edymtt/remove-old-way-of-building-compiler-rt branch from 8b7eda3 to b7f8eb7 Compare June 11, 2025 21:43
@edymtt
Copy link
Contributor Author

edymtt commented Jun 11, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci please test WIndows

@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt edymtt marked this pull request as ready for review June 12, 2025 13:54
@edymtt
Copy link
Contributor Author

edymtt commented Jun 12, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jun 13, 2025

@swift-ci please build toolchain Windows

@edymtt
Copy link
Contributor Author

edymtt commented Jun 16, 2025 •
edited
Loading

The build of the Windows toolchain is timing out -- from https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5926/console

lld-link: warning: T:\\x86_64-unknown-windows-msvc\\PackageManagerTests\\x86_64-unknown-windows-msvc\\release\\swift_package_manager.build\\SwiftPM.swift.o: locally defined symbol imported: $s8TSCBasic12RelativePathV18basenameWithoutExtSSvg (defined in T:\\x86_64-unknown-windows-msvc\\PackageManagerTests\\x86_64-unknown-windows-msvc\\release\\TSCBasic.build\\Path.swift.o) [LNK4217]

[996/997] Linking SwiftPMPackageTests.xctest
Build complete! (1196.88s)
Build timed out (after 60 minutes). Marking the build as aborted.

Not entirely sure this is due to this PR, since I am not touching any code used by the Windows build.

@edymtt
Copy link
Contributor Author

edymtt commented Jun 16, 2025

@swift-ci please build toolchain Windows

edymtt added a commit to edymtt/swift that referenced this pull request Jun 16, 2025
@edymtt
[DNM] Test generation of Windows Toolchain in PR testing
623e8a1 
Figuring out if the timeouts I get for swiftlang#82124 are related to those
changes.
@edymtt edymtt mentioned this pull request Jun 16, 2025
Closed
@edymtt
Copy link
Contributor Author

edymtt commented Jun 16, 2025

(According to #82265, the Windows toolchain issue is unrelated to this PR)

@edymtt edymtt merged commit d3f8bbf into swiftlang:main Jun 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde approved these changes

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edymtt @etcwilde