build: Ensure static headers are always symlinked #82125
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Swift static build on Windows, projects like Foundation use the clang headers from the toolchain build `lib` directory. No target in the toolchain build depends on the static clang headers, so they do not get installed. As a workaround, this makes the static clang headers symlink target a dependency of the regular dynamic version of the headers, ensuring they are installed as part of the toolchainb build.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Swift static build on Windows, projects like Foundation use the clang headers from the toolchain build
libdirectory. No target in the toolchain build depends on the static clang headers, so they do not get installed. As a workaround, this makes the static clang headers symlink target a dependency of the regular dynamic version of the headers, ensuring they are installed as part of the toolchain build.