Sema: Don't expand macros when binding extensions #82129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
bind-extensions-macro
branch
from
45bcd69 to
ccad0e1
Compare
slavapestov
force-pushed
the
bind-extensions-macro
branch
from
ccad0e1 to
f6b18eb
Compare
slavapestov
requested review from
xymus,
artemcm,
tshortli,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
Macro expansion can call typeCheckExpr(), which performs qualified lookups. So if we expand macros while binding extensions, these qualified lookups can fail because they cannot find members of extensions that have not been bound yet. To fix this, try binding extensions without performing macro expansion first. If any extensions remain at the end, we fall back to the old behavior, and try to bind them again, this time performing macro expansion. Fixes rdar://149798059.
slavapestov
force-pushed
the
bind-extensions-macro
branch
from
f6b18eb to
63a5731
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
slavapestov
added a commit
that referenced
this pull request
Jun 23, 2025
Sema: Add missing test case for #82129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that macro expansion can trigger expression type checking, which performs arbitrary name lookups, which can then fail if not all extensions have been bound yet.
To maintain source compatibility, we attempt extension binding a second time if anything fails, this time allowing macro expansion.
Fixes rdar://149798059.