Skip to content

Fix MoveOnlyWrappedTypeEliminator handling of store_borrow. #82137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jun 10, 2025

Defer visiting an instruction until its operands have been visited. Otherwise,
this pass will crash during ownership verification with invalid operand
ownership.

Fixes rdar://152879038 ([moveonly] MoveOnlyWrappedTypeEliminator ownership
verifier crashes on @_addressableSelf)

Defer visiting an instruction until its operands have been visited. Otherwise,
this pass will crash during ownership verification with invalid operand
ownership.

Fixes rdar://152879038 ([moveonly] MoveOnlyWrappedTypeEliminator ownership
verifier crashes on @_addressableSelf)
@atrick
Copy link
Contributor Author

atrick commented Jun 10, 2025

@swift-ci test

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atrick
Copy link
Contributor Author

atrick commented Jun 10, 2025

Full PR testing is failing on main

@atrick
Copy link
Contributor Author

atrick commented Jun 10, 2025

@swift-ci smoke test

@atrick
Copy link
Contributor Author

atrick commented Jun 10, 2025

From the linux build log I can't tell what is failing.

@atrick
Copy link
Contributor Author

atrick commented Jun 10, 2025

@swift-ci smoke test linux

@atrick atrick merged commit c2271e2 into swiftlang:main Jun 10, 2025
3 of 5 checks passed
@atrick atrick deleted the fix-moveonly-storeborrow branch June 10, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants