[cxx-interop] Fix crash in ASTMangler triggered by UsingShadowDecls #82144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
hborla,
slavapestov and
xedin
as code owners
egorzhdan
approved these changes
Jun 10, 2025
hnrklssn
reviewed
Jun 10, 2025
Xazax-hun
force-pushed
the
gaborh/using-shadow-decl-mangling
branch
from
b5fc135 to
72d3c9c
Compare
We did not handle this declaration kind. This PR introduces makes sure we mangle it the same way we do for the target declaration. Fixes #82108.
hnrklssn
approved these changes
Jun 10, 2025
Xazax-hun
force-pushed
the
gaborh/using-shadow-decl-mangling
branch
from
72d3c9c to
059051c
Compare
|
@swift-ci please smoke test |
j-hui
approved these changes
Jun 10, 2025
Xazax-hun
added a commit
that referenced
this pull request
Jun 11, 2025
Explanation: We did not handle this declaration kind. This PR makes sure we mangle it the same way we do for the target declaration. Issue: rdar://152841420 Risk: Low, the fix is small, localized, and straightforward. Testing: Regression test added. Original PR: #82144 Reviewer: @egorzhdan @hnrklssn @j-hui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not handle this declaration kind. This PR makes sure we mangle it the same way we do for the target declaration.
Fixes #82108.