🍒 [6.2] line-directive: Stop expanding response files #82166
Merged
+24
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive-stop-expanding-rsp line-directive: Stop expanding response files
…ive-update-comment line-directive: Update outdated comment
…ive-stop-expanding-response-files line-directive: Actually stop expanding response files
Steelskin
changed the title
|
@swift-ci please test |
bnbarham
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line-directivewas expanding response files for the swiftc invocation, which was causing issues on CI when the file list got too long. This changes the script to stop expanding response files and pass them as-is to the swiftc invocation instead. The format for the response files was also incorrect, with each individual file being quoted, so this fixes the CMake script generating those.Finally, this changes
line-directiveto dump the command line on failure.This fixes the response file format and removes the expansion of the response file in
line-directive. The scope is limited and should prevent issues on the release branch like the ones we saw on main.N/A
line-directive: Stop expanding response files #81996
line-directive: Update outdated comment #82023
line-directive: Actually stop expanding response files #82028
Very low risk, CI should catch any potential issue.
Local build on main + CI
@compnerd
@etcwilde