[Observation] Initial implementation of Observed for transactional tracked values over time (#79817) #82197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acked values over time (swiftlang#79817) This is an implementation for the feature swiftlang/swift-evolution#2726
|
@swift-ci test |
| /// `Observations` conforms to `AsyncSequence`, providing a intutive and safe mechanism to track changes to | ||
| /// types that are marked as `@Observable` by using Swift Concurrency to indicate transactional boundaries | ||
| /// starting from the willSet of the first mutation to the next suspension point of the safe access. | ||
| @available(SwiftStdlib 9999, *) |
There was a problem hiding this comment.
(SwiftStdlib 6.2, *)
stephentyrone
approved these changes
Jun 11, 2025
|
@swift-ci please test |
jamieQ
reviewed
Jun 12, 2025
| operation: @isolated(any) () async throws -> T, | ||
| onCancel handler: @Sendable () -> Void, | ||
| isolation: isolated (any Actor)? = #isolation | ||
| ) async rethrows -> T { |
There was a problem hiding this comment.
if i understand correctly the motivation for this (to deal with the isolation crossing issue i raised in an earlier iteration), it's not clear to me that the runtime hacks are necessary. can't you just pass the iterationIsolation through the relevant closures to ensure that the isolation of the operation and isolation parameters in the 'normal' cancellation handler function match? then there should be no dynamic suspension when awaiting the operation.
There was a problem hiding this comment.
I want to discuss this further, but let's do it in a separate issue thread (#82205).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
This is an implementation for the feature
[Observation] Proposal to add a transactional observation of values swift-evolution#2726
Scope:
This is targeted specifically to the Observation module, no language or runtime changes
Issues:
Original PRs:
[Observation] Initial implementation of Observed for transactional tracked values over time #79817
Risk:
Low
Testing:
This was tested in external forms (which need to be merged in)
Reviewers: