[6.2][TypeChecker] Remove @_inheritActorContext effect from synchronous types
#82209
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types The compiler would previously accept use of `@_inheritActorContext` on a parameter with a synchronous function type which wasn't marked as `@isolated(any)`. That is incorrect because in such cases the attribute has no effect and furthermore would prevent Sendable and isolation checking. Uses like that are currently diagnosed by the type-checker but we need to go one step further and remove the effect in such case to prevent invalid uses. Resolves: rdar://143581268 (cherry picked from commit dbe19b6)
|
@swift-ci please test |
hborla
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82157
Explanation:
The compiler would previously accept use of
@_inheritActorContexton a parameter with a synchronous function type which wasn't marked as@isolated(any). That is incorrect because in such cases the attribute has no effect and furthermore would prevent Sendable and isolation checking.Uses like that are currently diagnosed by the type-checker but we need to go one step further and remove the effect in such case to prevent invalid uses.
Resolves: rdar://143581268
Main Branch PR: [TypeChecker] Remove
@_inheritActorContexteffect from synchronous … #82157Risk: Low/Medium. It's possible that some uses of APIs that use
@_inheritActorContextincorrectly are now going to be diagnosed as errors.Reviewed By: @hborla @ktoso
Testing: Added new test-cases to the test suite.
(cherry picked from commit dbe19b6)