Skip to content

Add benchmarks for lengthOfBytes(using:) #82248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add benchmarks for lengthOfBytes(using:) #82248

wants to merge 5 commits into from
+67 −2

Conversation

Catfish-Man
Copy link
Contributor

No description provided.

@Catfish-Man Catfish-Man self-assigned this Jun 13, 2025
@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

These are to get benchmark coverage for #81791

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please Apple Silicon benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man Catfish-Man marked this pull request as ready for review June 14, 2025 16:55
@Catfish-Man Catfish-Man requested a review from eeckstein as a code owner June 14, 2025 16:55
@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

eeckstein
eeckstein reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reduce the number of individual benchmarks?
E.g. by picking a few relevant benchmarks and marking the others as "skip".
Or by combining multiple into one?

@Catfish-Man
Copy link
Contributor Author

Hmm. I suppose I could combine them. My concern is that accidentally regressing one case while massively progressing the others (which is a fairly likely outcome of my other PR!) would look like a big win.

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@Catfish-Man Catfish-Man changed the title Add benchmarks for lengthOfBytes(using:) and maximumLengthOfBytes(using:) Add benchmarks for lengthOfBytes(using:) Jun 24, 2025
eeckstein
eeckstein approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@Catfish-Man Catfish-Man enabled auto-merge (squash) June 25, 2025 20:48
@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@Catfish-Man
Copy link
Contributor Author

CI failure should be fixed by swiftlang/swift-driver#1940

@etcwilde
Copy link
Member

swiftlang/swift-driver#1940
@swift-ci please test macOS

@Catfish-Man
Copy link
Contributor Author

swiftlang/swift-driver#1940
@swift-ci please test macOS

@Catfish-Man
Copy link
Contributor Author

Please test with following PR:
swiftlang/swift-driver#1940
@swift-ci please test

auto-merge was automatically disabled June 26, 2025 22:19

Pull request was closed

@Catfish-Man
Copy link
Contributor Author

I'm just going to land this as part of the main commit

@Catfish-Man Catfish-Man deleted the a-lengthy-task-benchmarks branch June 27, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Catfish-Man @etcwilde @eeckstein