Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

[WIP] Revisiting structure part 1 #551

Merged
merged 5 commits into from
Aug 25, 2014
Merged

[WIP] Revisiting structure part 1 #551

merged 5 commits into from
Aug 25, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 23, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets partly #523

During this Community Hack Day, I'll try to work on the revisited doc structure.

@@ -430,8 +421,15 @@ not configure anything here, the ODM services will not be loaded.

.. tip::

If you want to only use plain PHPCR without the PHPCR-ODM, you can simply
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think having this at the top makes it more likely for people to notice it. when its at the end, they already tried to understand documentation for things they did not need, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thisnote is about the odm config ism't it? Before, it was placed at the top, I've moved it to just before the odm option. That's more logical to me and it means it's also visible if someone used a headline link to odm directly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, not seen enough context then. yeah, totally makes sense, thanks!

@dbu
Copy link
Member

dbu commented Aug 25, 2014

hey, great work!

as usual with big restructuring, i would love to merge this as soon as possible, when it has an ok status, and work with follow-up PRs instead of leaving this open for too long and get into conflicts with other contributions.

@wouterj wouterj force-pushed the revisiting_structure branch from 259403d to 8ed7872 Compare August 25, 2014 09:49
@wouterj wouterj force-pushed the revisiting_structure branch from e95a207 to cc69c55 Compare August 25, 2014 10:03
wouterj added a commit that referenced this pull request Aug 25, 2014
@wouterj wouterj merged commit ce633f1 into master Aug 25, 2014
@wouterj wouterj deleted the revisiting_structure branch August 25, 2014 10:05
@dantleech
Copy link
Member

Sorry to have not reviewed this PR in detail, but should we really have the Creating a Basic CMS as the only tutorial at this stage (tutorial/<>) ? Is this not a little premature? It is not a tutorial which explains "all" the stuff in the CMF.

Also.. I am doing a workshop on Monday that uses this documentation .. so please don't change anything else until after that :P

@wouterj
Copy link
Member Author

wouterj commented Aug 30, 2014

You've had great ideas about the tutorial, but we need more time before e can start writing it.

The Creating a Cms is the most popular part of the docs, that's why I moved it to a better place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants