forked from react-toolbox/react-toolbox
-
Notifications
You must be signed in to change notification settings - Fork 0
New dev #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cnunez01
wants to merge
225
commits into
react-toolbox12
Choose a base branch
from
new-dev
base: react-toolbox12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New dev #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it works, but produces a warning by react typechecking
* 'dev' of github.com:soyjavi/react-toolbox: ListItem legend may be a node as well (react-toolbox#1496) Allow pass inverse to IconMenu (react-toolbox#1490) Fix media queries panel height calculations (react-toolbox#1467) Allow to change FontIcon for Tab by passing it into the factory (react-toolbox#1439) Added required?: boolean; (react-toolbox#1491)
…ows coordinate runtime positioning of the portal element using top/left/bottom/right values (react-toolbox#1502)
Added correct proptypes on `ListItemLayout` and updated documentation for ListItem's fields `legend` and `caption`.
…ble. If the browser tab is put to the background, requestAnimationFrame will trigger when the tab returned to the foreground. When the Tabs Component is removed from the DOM when in the background, the requestAnimationFrame must be canceled to prevent attempting to use a unmounted Component. (react-toolbox#1604)
The channel doesn't exist anymore related to react-toolbox#107
* update webpack config to make "Basic usage" work.
I use webpack version 2.6 and new configure syntax rather than 1.x.
When I follow the instruction on `readme.md`. It always failed on *Basic Usage* with the message below.
``` bash
ERROR in ./~/css-loader?{"modules":false,"importLoaders":1,"localIdentName":"[name]--[local]--[hash:base64:8]"}!./~/postcss-loader/lib!./~/react-toolbox/lib/button/theme.css
Module build failed: Error: composition is only allowed when selector is single :local class name not in ".raised", ".raised" is weird
```
So I figured out what's wrong and update `reame.md` to notify others.
* edit multiple number.
According to docs, the width is larger than 320px and if the device is mobile than 280px. To follow this specification It should be 5, not 4.
This has been overlooked in PR react-toolbox#1407.
* Corresponds to `accept` attribute on `<input type="file"` * Allows defining which type of files are to be listed * Defaults to `*/*` which means all MIME types Not documented nor tested in the original, it remains so.
* Change tab style for ripple to work Changing element position to relative and overflow hidden. * Changing CSS props order
…1518) Add variables for the App Bar's font size and weight and align the defaults to Google's Material Design specs, which say "Across form factors, text that appears in the app bar should use the Title style, Medium 20sp." (see https://material.io/guidelines/style/typography.html).
* Update tabs for a11y * Use transition for background and set a11y for tab content * Remove unneccessary tabIndex from tab content * Fix lint issues
* Add $input-icon-right-space var to add the correct spacing to the input based on Material Spec. https://material.io/guidelines/components/text-fields.html#text-fields-s ingle-line-text-field * Fix Mobile Safari Issues. Remove added border-radius for inputs from Safari. Fix `Object.entries is not a function` for autocomplete. * Remove new line. * Add callback functions to slider for when slider starts being dragged, and when it stops.
…et value on slider test
…s-chunks-plugin, and add cold to enable avatar type checking
…upgrades [chore] several maintenance upgrades
rename all *.css to *.module.css
fix css-transition animation for date & time picker
fix(Dropdown): fix Dropdown not closing when click , resolves react-toolbox#1865
…colors in readme
Fix react-toolbox#1904 - update filename reference for variables and colors in readme
React toolbox12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.