-
Notifications
You must be signed in to change notification settings - Fork 60
api: remove box.session.push usage #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
oleg-jukovec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rebase on the master branch and re-format the commit message (update prefix and just to make it look better):
api: removed deprecated methods
Removed `box.session.push()` usage:
* `Future.AppendPush()`, `Future.GetIterator()` methods;
* `ResponseIterator` and `TimeoutResponseIterator` types;
* `pushes[]` field in `Future` and related methods.
Closes #480
Also, it would be a good idea to clean up here:
Lines 177 to 183 in 802aa24
| local function push_func(cnt) | |
| for i = 1, cnt do | |
| box.session.push(i) | |
| end | |
| return cnt | |
| end | |
| rawset(_G, 'push_func', push_func) |
connection.go
Outdated
| conn.opts.Logger.Report(LogAppendPushFailed, conn, err) | ||
| } | ||
| } | ||
| // not implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we need to add a log message here, something like:
unexpected IPTOTO_CHUNK for request %d, box.session.push is unsupported
and a test for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing Lua push_func, the IPROTO_CHUNK occurrence is no longer possible. Maybe we need to completely remove IPROTO_CHUNK mention? (furthermore, I've already written in changelog.md that I deleted it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add a test to the IPROTO_CHUNK log message, then you can leave the function as it will be used.
79d57c0 to
9a11b11
Compare
Removed `box.session.push()` usage: * `push_func()` function in `config.lua`; * `Future.AppendPush()`, `Future.GetIterator()` methods; * `ResponseIterator` and `TimeoutResponseIterator` types; * `pushes[]` field in `Future` and related methods. Closes #480
9a11b11 to
e0f51d9
Compare
| } | ||
| } | ||
| // IPROTO_CHUNK is unexpected because box.session.push is unsupported. | ||
| log.Printf("unexpected IPROTO_CHUNK for request %d", header.RequestId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPROTO_CHUNK relates to an implementation detail that not everyone understands. It's best to make a statement like this.
A push message is expected, but not supported.
| log.Printf("unexpected IPROTO_CHUNK for request %d", header.RequestId) | |
| log.Printf("unsupported box.session.push() for request %d", header.RequestId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a test for the message if possible.
Removed
box.session.push()usage:Future.AppendPush(),Future.GetIterator()methods,ResponseIteratorandTimeoutResponseIteratortypes,pushes[]field inFutureand related methods.Removed tests which became unnecessary.
I didn't forget about (remove if it is not applicable):
Closes #480