Skip to content

Conversation

@laines-it
Copy link
Collaborator

Removed box.session.push() usage:
Future.AppendPush(), Future.GetIterator() methods,
ResponseIterator and TimeoutResponseIterator types,
pushes[] field in Future and related methods.
Removed tests which became unnecessary.

I didn't forget about (remove if it is not applicable):

Closes #480

@laines-it laines-it changed the title pushAPI: removed deprecated methods pushAPI: remove box.session.push usage Nov 8, 2025
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase on the master branch and re-format the commit message (update prefix and just to make it look better):

api: removed deprecated methods

Removed `box.session.push()` usage:

* `Future.AppendPush()`, `Future.GetIterator()` methods;
* `ResponseIterator` and `TimeoutResponseIterator` types;
* `pushes[]` field in `Future` and related methods.

Closes #480

Also, it would be a good idea to clean up here:

go-tarantool/config.lua

Lines 177 to 183 in 802aa24

local function push_func(cnt)
for i = 1, cnt do
box.session.push(i)
end
return cnt
end
rawset(_G, 'push_func', push_func)

connection.go Outdated
conn.opts.Logger.Report(LogAppendPushFailed, conn, err)
}
}
// not implemented
Copy link
Collaborator

@oleg-jukovec oleg-jukovec Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we need to add a log message here, something like:

unexpected IPTOTO_CHUNK for request %d, box.session.push is unsupported

and a test for it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing Lua push_func, the IPROTO_CHUNK occurrence is no longer possible. Maybe we need to completely remove IPROTO_CHUNK mention? (furthermore, I've already written in changelog.md that I deleted it)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a test to the IPROTO_CHUNK log message, then you can leave the function as it will be used.

@laines-it laines-it force-pushed the laines-it/gh-480-remove-deprecated-pushapi branch 2 times, most recently from 79d57c0 to 9a11b11 Compare November 9, 2025 13:22
Removed `box.session.push()` usage:

* `push_func()` function in `config.lua`;
* `Future.AppendPush()`, `Future.GetIterator()` methods;
* `ResponseIterator` and `TimeoutResponseIterator` types;
* `pushes[]` field in `Future` and related methods.

Closes #480
@laines-it laines-it force-pushed the laines-it/gh-480-remove-deprecated-pushapi branch from 9a11b11 to e0f51d9 Compare November 9, 2025 13:29
}
}
// IPROTO_CHUNK is unexpected because box.session.push is unsupported.
log.Printf("unexpected IPROTO_CHUNK for request %d", header.RequestId)
Copy link
Collaborator

@oleg-jukovec oleg-jukovec Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPROTO_CHUNK relates to an implementation detail that not everyone understands. It's best to make a statement like this.

A push message is expected, but not supported.

Suggested change
log.Printf("unexpected IPROTO_CHUNK for request %d", header.RequestId)
log.Printf("unsupported box.session.push() for request %d", header.RequestId)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test for the message if possible.

@oleg-jukovec oleg-jukovec changed the title pushAPI: remove box.session.push usage api: remove box.session.push usage Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3: remove all deprecated methods re obsolete push API

3 participants