Skip to content

Simpler call interface #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vanderlee
Copy link

The current call interface (API) to toastmessage is somewhat uncommon and needlessly complicated. This is my simplified interface

Current:
$().toastmessage('showNoticeToast', 'some message here');

In my version:
$.toastmessage('notice', 'some message here');

Basically, it rids of the uncommon and wasteful '$()' notation and shortens the 'method' strings.

Additionally, you can now add a boolean to indicate stickyness. I use this particular switch for half the messages and this way I don't have to drop down to the object-using syntax.

@LorenDorez
Copy link

I Agree with @vanderlee

Also something like $.toastmessage.Notice('some message here'); would be even better.

@alesnav
Copy link

alesnav commented Jun 15, 2014

I think this should be merged...

@dbremer-tonn , is this dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants