Version Packages #8397
Version Packages #8397
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughVersion bumps across multiple packages (thirdweb → 5.112.0, nebula → 0.2.89, wagmi-adapter → 0.2.186, wagmi-demo → 0.0.31), changelog updates, and deletion of a changeset file that previously documented a Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Bridge as Bridge.Webhook
participant Verifier as PayloadVerifier
Client->>Bridge: parse(body, headers, secret, tolerance, options?)
alt options provided
Bridge->>Verifier: verify(payload, options)
Verifier-->>Bridge: verification result
alt verified
Bridge-->>Client: parsed webhook object (verified)
else failed
Bridge-->>Client: throw/return verification error
end
else no options
Bridge-->>Client: parsed webhook object (no extra verification)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/thirdweb/CHANGELOG.md (2)
11-24: Tighten the example: define tolerance, note server-side usage, and hint at verify shape
- Show a concrete tolerance value and its unit (seconds) to avoid “undefined variable” confusion.
- Add a short note that WEBHOOK_SECRET must be used server-side only.
- Briefly list or link the allowed fields for the verify parameter so users know what can be validated beyond receiverAddress.
Suggested tweak:
import { Bridge } from "thirdweb"; + // tolerance in seconds (optional; defaults to … if omitted) + const tolerance = 300; + // Note: use WEBHOOK_SECRET only on the server (Node/Edge), never in the browser. + const payload = await Bridge.Webhook.parse( body, headers, process.env.WEBHOOK_SECRET, tolerance, { // throw an error if the `payload` doesn't have this receiver address set receiverAddress: "0x1234567890123456789012345678901234567890", }, );If there are other verify options (e.g., event types, chainId, provider), please add a brief bullet or a docs link.
7-7: Clarify naming/import to avoid confusion with priorWebhook.parsedocsEarlier entries referenced
Webhook.parse(e.g., underthirdweb/bridge). This entry usesBridge.Webhook.parse. Add a one-liner noting this is the same API surface (now underBridge) or mention migration guidance if the old import path is deprecated, to prevent user confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.changeset/mean-pants-beam.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/mean-pants-beam.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.jsonapps/wagmi-demo/package.json
🧠 Learnings (5)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonapps/wagmi-demo/CHANGELOG.mdpackages/wagmi-adapter/CHANGELOG.mdapps/wagmi-demo/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to packages/thirdweb/exports/** : Export all public API via `packages/thirdweb/exports/`, grouped by feature
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.mdpackages/thirdweb/CHANGELOG.mdapps/wagmi-demo/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
apps/wagmi-demo/package.json (1)
4-4: Version bump is consistent with dependency updates.Version 0.0.31 aligns with the updated dependencies ([email protected], @thirdweb-dev/[email protected]) documented in the changelog.
packages/nebula/package.json (1)
60-60: Version bump is consistent with thirdweb dependency update.Patch version 0.2.89 correctly reflects the dependency update to [email protected] with no API surface changes.
packages/wagmi-adapter/package.json (1)
59-59: Version bump is consistent with coordinated monorepo release.Patch version 0.2.186 is appropriate for this coordinated dependency update across the monorepo.
apps/wagmi-demo/CHANGELOG.md (1)
3-10: Changelog entry is properly formatted and consistent.The new 0.0.31 entry correctly documents dependency updates to [email protected] and @thirdweb-dev/[email protected] with appropriate commit reference. Formatting follows Changesets convention.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog entry correctly reflects version bump.The new 0.2.186 heading is properly positioned and follows the established changelog pattern. Empty entries (without Patch Changes details) are consistent with this file's structure for versions with no user-facing changes to document.
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and consistent with dependency updates.The new 0.2.89 entry correctly documents the [email protected] dependency update with proper Changesets formatting and commit traceability.
packages/thirdweb/package.json
Outdated
| }, | ||
| "typings": "./dist/types/exports/thirdweb.d.ts", | ||
| "version": "5.111.10" | ||
| "version": "5.111.11" |
There was a problem hiding this comment.
🧩 Analysis chain
Verify that a patch version bump is appropriate for the Bridge.Webhook.parse API change.
According to the PR objectives, this release adds a new verify parameter to the public Bridge.Webhook.parse method for payload validation. Based on learnings in this repo, new or modified public API typically warrants a minor version bump rather than a patch. If the verify parameter is optional and maintains full backward compatibility, a patch bump is acceptable; otherwise, this should be 5.112.0 (minor).
🏁 Script executed:
#!/bin/bash
# Description: Verify the changeset content to confirm parameter optionality and backward compatibility.
# Find and display the changeset file for thirdweb package
find .changeset -name "*.md" -type f | head -20 | xargs cat
# Also check if size-limit config exists in the file or elsewhere
echo "=== Checking for size-limit configuration ==="
grep -i "size-limit" packages/thirdweb/package.json || echo "No size-limit config found in package.json"
find packages/thirdweb -name ".size-limit.*" -o -name "size-limit.config.*" 2>/dev/null || echo "No size-limit config file found"Length of output: 688
---
🏁 Script executed:
```shell
#!/bin/bash
# Get changeset content and size-limit config
# Read .size-limit.json to confirm configuration
echo "=== Size-limit configuration ==="
cat packages/thirdweb/.size-limit.json 2>/dev/null || echo "File not readable"
# Find actual changeset markdown files (not README)
echo "=== Changeset files (excluding README) ==="
find .changeset -name "*.md" -type f ! -name "README.md" | head -10
# Read the changeset files for this PR
echo "=== Changeset content ==="
find .changeset -name "*.md" -type f ! -name "README.md" -exec cat {} \;
# Search for Bridge.Webhook.parse to verify parameter changes
echo "=== Bridge.Webhook.parse changes ==="
rg -n "Bridge\.Webhook\.parse\|verify.*parameter" -A5 -B5 packages/thirdweb/src --type=ts --type=js 2>/dev/null | head -50
Length of output: 896
---
🏁 Script executed:
```shell
#!/bin/bash
# Search for Bridge.Webhook and understand codebase structure
echo "=== Searching for Bridge.Webhook implementation ==="
rg -n "class.*Bridge|Webhook\|export.*Bridge" packages/thirdweb/src -A3 -B1 --type=ts --type=js | head -80
echo "=== Looking for parse method in Bridge context ==="
rg -n "parse\s*\(" packages/thirdweb/src -B3 --type=ts --type=js | grep -i "bridge\|webhook" -A3 -B3 | head -40
echo "=== Checking for verify parameter in recent changes ==="
rg -n "verify\s*[:?]" packages/thirdweb/src --type=ts --type=js | head -20
echo "=== Listing Bridge/Webhook related files ==="
find packages/thirdweb/src -name "*bridge*" -o -name "*webhook*" 2>/dev/null
Length of output: 4888
---
🏁 Script executed:
```shell
#!/bin/bash
# Read Webhook.ts to understand parse method and verify parameter
echo "=== Webhook.ts parse method and verify parameter ==="
cat packages/thirdweb/src/bridge/Webhook.ts | head -200
echo ""
echo "=== Webhook.test.ts verify-related test cases ==="
grep -A20 "verify" packages/thirdweb/src/bridge/Webhook.test.ts | head -80
Length of output: 8245
Version bump should be minor (5.112.0), not patch, for the new verify parameter.
The parse() method in Bridge.Webhook now accepts a new optional verify parameter for payload validation. Although backward-compatible (since it's optional), adding a new parameter to a public API requires a minor version bump per semantic versioning and repo guidelines. Update the version to 5.112.0.
🤖 Prompt for AI Agents
In packages/thirdweb/package.json around line 433, the version is incorrectly
set to a patch bump "5.111.11"; because Bridge.Webhook.parse() gained a new
optional public parameter `verify`, update the version to the appropriate minor
bump "5.112.0". Modify the version field to "5.112.0" and ensure package-lock or
any related release metadata is updated accordingly before committing.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8397 +/- ##
=======================================
Coverage 54.82% 54.82%
=======================================
Files 919 919
Lines 60843 60843
Branches 4135 4136 +1
=======================================
Hits 33359 33359
+ Misses 27383 27382 -1
- Partials 101 102 +1
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
75343b7 to
25c8b50
Compare
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
25c8b50 to
7d7213a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Empty changelog entry for 0.2.186.The new version heading is properly formatted and placed, but the entry lacks any documentation of changes (no
### Patch Changessection). This follows the repository's existing pattern—many versions have empty entries—but typically dependency-only bumps are documented to help users understand why a patch was released.Consider adding a note if this version includes dependency updates (e.g., thirdweb to 5.112.0) that warrant documentation, or rely on the existing convention if that's the standard practice for your repository.
If dependency updates should be documented, consider adding a
### Patch Changessection:## 0.2.186 + +### Patch Changes + +- Updated dependencies to [email protected] ## 0.2.185Alternatively, if this follows your repository's standard practice for transitive dependency-only updates, you can disregard this comment.
packages/thirdweb/CHANGELOG.md (1)
17-30: Tighten example: rename result variable, annotate tolerance, and label verify options.
- Use a non-ambiguous result name (e.g.,
webhook) instead ofpayloadwhile the first arg isbody.- Add a brief note that
toleranceis in seconds.- Consider a comment indicating the last arg is “verify options.”
Suggested edit:
- const payload = await Bridge.Webhook.parse( + const webhook = await Bridge.Webhook.parse( body, headers, process.env.WEBHOOK_SECRET, - tolerance, - { - // throw an error if the `payload` doesn't have this receiver address set - receiverAddress: "0x1234567890123456789012345678901234567890", - }, + tolerance, // seconds + { // verify options + // throw if the parsed payload's receiver does not match + receiverAddress: "0x1234567890123456789012345678901234567890", + }, );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
.changeset/clean-tools-learn.md(0 hunks).changeset/mean-pants-beam.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/clean-tools-learn.md
- .changeset/mean-pants-beam.md
✅ Files skipped from review due to trivial changes (1)
- packages/wagmi-adapter/package.json
🚧 Files skipped from review as they are similar to previous changes (5)
- apps/wagmi-demo/CHANGELOG.md
- packages/nebula/package.json
- apps/wagmi-demo/package.json
- packages/nebula/CHANGELOG.md
- packages/thirdweb/package.json
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
Repo: thirdweb-dev/js PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
| - [#8395](https://github.com/thirdweb-dev/js/pull/8395) [`a54c1ab`](https://github.com/thirdweb-dev/js/commit/a54c1aba350bf1672b2c3fc1ffc702cf2e36bb49) Thanks [@MananTank](https://github.com/MananTank)! - Add `verify` parameter to `Bridge.Webhook.parse` function to validate the payload | ||
|
|
There was a problem hiding this comment.
Clarify “verify parameter” vs options object.
The bullet says “Add verify parameter,” but the example passes an options object as the 5th argument. Either reword to “verify options parameter” or show the param name/shape to avoid ambiguity (e.g., list available fields like receiverAddress).
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around lines 13 to 14, the entry “Add `verify`
parameter to `Bridge.Webhook.parse` function” is ambiguous because the example
uses an options object; update the bullet to either read “Add `verify` options
parameter to `Bridge.Webhook.parse`” or expand the entry to include the
parameter name and shape (e.g., `verify: { receiverAddress?: string, ... }`) and
list the available fields (such as receiverAddress) so readers know it’s an
options object and what keys it accepts.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
d0bbbfdThanks @joaquim-verges! - Add all connected wallets in all onConnect callbacksPatch Changes
#8402
e26d81cThanks @joaquim-verges! - Update useAuthToken() to find the auth token for any connected wallet instead of just the active one#8395
a54c1abThanks @MananTank! - Addverifyparameter toBridge.Webhook.parsefunction to validate the payloadExample
@thirdweb-dev/[email protected]
Patch Changes
e26d81c,d0bbbfd,a54c1ab]:@thirdweb-dev/[email protected]
[email protected]
Patch Changes
e26d81c,d0bbbfd,a54c1ab]:PR-Codex overview
This PR focuses on updating version numbers across multiple packages and enhancing the changelogs with recent changes, including dependency updates and new features.
Detailed summary
versioninpackages/thirdweb/package.jsonto5.112.0versioninapps/wagmi-demo/package.jsonto0.0.31versioninpackages/nebula/package.jsonto0.2.89versioninpackages/wagmi-adapter/package.jsonto0.2.186[email protected],@thirdweb-dev/[email protected], andapps/[email protected]with details on new features and updates.Summary by CodeRabbit
New Features
Chores