Skip to content

Commit a806111

Browse files
author
Stephane Landelle
committed
Rename sendTextMessage into sendMessage and streamText into stream, close AsyncHttpClient#671
1 parent b0de550 commit a806111

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

api/src/main/java/org/asynchttpclient/websocket/WebSocket.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public interface WebSocket extends Closeable {
5252
* @param message a text message
5353
* @return this.
5454
*/
55-
WebSocket sendTextMessage(String message);
55+
WebSocket sendMessage(String message);
5656

5757
/**
5858
* Allows streaming of multiple text fragments.
@@ -61,7 +61,7 @@ public interface WebSocket extends Closeable {
6161
* @param last flag indicating whether or not this is the last fragment.
6262
* @return this.
6363
*/
64-
WebSocket streamText(String fragment, boolean last);
64+
WebSocket stream(String fragment, boolean last);
6565

6666
/**
6767
* Send a <code>ping</ping> with an optional payload

api/src/test/java/org/asynchttpclient/websocket/ProxyTunnellingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public void onError(Throwable t) {
116116
}
117117
}).build()).get();
118118

119-
websocket.sendTextMessage("ECHO");
119+
websocket.sendMessage("ECHO");
120120

121121
latch.await();
122122
assertEquals(text.get(), "ECHO");

api/src/test/java/org/asynchttpclient/websocket/TextMessageTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ public void onError(Throwable t) {
200200
}
201201
}).build()).get();
202202

203-
websocket.sendTextMessage("ECHO");
203+
websocket.sendMessage("ECHO");
204204

205205
latch.await();
206206
assertEquals(text.get(), "ECHO");
@@ -262,7 +262,7 @@ public void onError(Throwable t) {
262262
}
263263
}).build()).get();
264264

265-
websocket.sendTextMessage("ECHO");
265+
websocket.sendMessage("ECHO");
266266

267267
latch.await();
268268
assertEquals(text.get(), "ECHOECHO");
@@ -288,7 +288,7 @@ public void onMessage(String message) {
288288

289289
@Override
290290
public void onOpen(WebSocket websocket) {
291-
websocket.sendTextMessage("ECHO").sendTextMessage("ECHO");
291+
websocket.sendMessage("ECHO").sendMessage("ECHO");
292292
}
293293

294294
@Override
@@ -340,8 +340,8 @@ public void onError(Throwable t) {
340340
}
341341
}).build()).get();
342342

343-
websocket.streamText("ECHO", false);
344-
websocket.streamText("ECHO", true);
343+
websocket.stream("ECHO", false);
344+
websocket.stream("ECHO", true);
345345

346346
latch.await();
347347
assertEquals(text.get(), "ECHOECHO");
@@ -382,10 +382,10 @@ public void onError(Throwable t) {
382382
}
383383
}).build()).get();
384384

385-
websocket.sendTextMessage("ECHO");
385+
websocket.sendMessage("ECHO");
386386
textLatch.await();
387387

388-
websocket.sendTextMessage("CLOSE");
388+
websocket.sendMessage("CLOSE");
389389
closeLatch.await();
390390

391391
assertEquals(text.get(), "ECHO");

providers/grizzly/src/main/java/org/asynchttpclient/providers/grizzly/websocket/GrizzlyWebSocketAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ public WebSocket stream(byte[] fragment, int offset, int len, boolean last) {
5656
}
5757

5858
@Override
59-
public WebSocket sendTextMessage(String message) {
59+
public WebSocket sendMessage(String message) {
6060
gWebSocket.send(message);
6161
return this;
6262
}
6363

6464
@Override
65-
public WebSocket streamText(String fragment, boolean last) {
65+
public WebSocket stream(String fragment, boolean last) {
6666
gWebSocket.stream(last, fragment);
6767
return this;
6868
}

providers/netty/src/main/java/org/asynchttpclient/providers/netty/ws/NettyWebSocket.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,13 @@ public WebSocket stream(byte[] fragment, int offset, int len, boolean last) {
8686
}
8787

8888
@Override
89-
public WebSocket sendTextMessage(String message) {
89+
public WebSocket sendMessage(String message) {
9090
channel.writeAndFlush(new TextWebSocketFrame(message));
9191
return this;
9292
}
9393

9494
@Override
95-
public WebSocket streamText(String fragment, boolean last) {
95+
public WebSocket stream(String fragment, boolean last) {
9696
channel.writeAndFlush(new TextWebSocketFrame(last, 0, fragment));
9797
return this;
9898
}

0 commit comments

Comments
 (0)