Skip to content

[README] WebSocket's sendBinaryMessage should be sendMessage #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ngocdaothanh opened this issue Aug 22, 2014 · 3 comments
Closed

[README] WebSocket's sendBinaryMessage should be sendMessage #671

ngocdaothanh opened this issue Aug 22, 2014 · 3 comments
Assignees
@slandelle
Milestone
1.9.0

Comments

@ngocdaothanh
Copy link

I think sendBinaryMessage is an old API.
@slandelle
Copy link
Contributor

We currently have sendTextMessage(String) vs sendMessage(byte) and streamText(String) vs stream(byte). @jfarcand Any reason for not having a single method name + overloading?

@slandelle slandelle self-assigned this Aug 23, 2014
@slandelle
Copy link
Contributor

@jfarcand ping

@slandelle slandelle added this to the 1.9.0 milestone Sep 4, 2014
slandelle pushed a commit that referenced this issue Sep 4, 2014
Rename sendTextMessage into sendMessage and streamText into stream, c…
35cdab3 
…lose #671
slandelle pushed a commit that referenced this issue Sep 4, 2014
Don't mention sendBinaryMessage but sendMessage, close #671
5e9a8ef
@jfarcand
Copy link
Contributor

jfarcand commented Sep 4, 2014

OK little bit late, but I agree with the change :-)

cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@dnadoba
Fix crash if connection is closed very early (AsyncHttpClient#671)
423fd0b 
* Fix crash if connection is closed very early

If the channel is closed before flatMap is executed, all ChannelHandler are removed and `TLSEventsHandler` is therefore not present either. We need to tolerate this even though it is very rare.

Testing ideas welcome.

Fixes AsyncHttpClient#670

* drop precondition to assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
3 participants
@ngocdaothanh @jfarcand @slandelle