Skip to content

Conversation

@ismail9k
Copy link

@ismail9k ismail9k commented Apr 27, 2020

This PR is mainly to fix URL validation for URL(s) with more than four characters TLD (e.g. .store, .online, .studio, .design, .international ...)

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the current behavior? (You can also link to an open issue here)
    It gives invalid URL message for URLs five-plus characters TLD (example this website https://mycatalog.store/)
  • What is the new behavior (if this is a feature change)?
    URLs with more than four characters TLD should tread as a valid URLs.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No breaking change
  • Other information:

@coveralls
Copy link

coveralls commented Apr 27, 2020

Coverage Status

Coverage remained the same at 89.979% when pulling 0eb342e on ismail9k:master into 721a4ee on vue-generators:master.

@zoul0813
Copy link
Member

If we’re going to fix this, should address the fact that TLD’s do not have a length limit... to my knowledge. There are some fairly large ones. I believe “business” is a TLD now for example.

The TLD should be validated if it contains valid chars, regardless of length...

@ismail9k
Copy link
Author

Yes, we should support all the currently available TLDs. However, I have searched for the list of available TLD, the characters count vary from 2 to around 24 characters. So, I suggest validating TLD to be a minimum of 2 characters without maximum.

@ismail9k ismail9k changed the title fix(validation): URL validation for URL(s) with five or six characters TLD fix(validation): URL validation for URL(s) with more than four characters TLD Apr 28, 2020
@ismail9k
Copy link
Author

ismail9k commented Dec 4, 2020

Any update on this :), when this PR will be available on the release version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants