Skip to content

feat: add vscode config for ESLint #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024
Merged

feat: add vscode config for ESLint #467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a1012f
feat: add vscode config for ESLint #466
yoshi-pi Mar 14, 2024
7ef6604
chore: add ESLint and Prettier to snapshot
yoshi-pi Mar 14, 2024
1a35397
refactor: move eslint and eslint-with-prettier as a separate feature …
yoshi-pi Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add ESLint and Prettier to snapshot
  • Loading branch information
@yoshi-pi
yoshi-pi committed Mar 14, 2024
commit 7ef6604e9744b9b07d14d7d6fadc42cfa2c879bf
2 changes: 2 additions & 0 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ async function init() {
argv.nightwatch ??
argv.playwright ??
argv.eslint ??
argv['eslint-with-prettier'] ??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

(argv.devtools || argv['vue-devtools'])
) === 'boolean'

Expand Down Expand Up @@ -463,6 +464,7 @@ async function init() {
needsPrettier,
needsPlaywright
})
render('config/eslint')
}

if (needsPrettier) {
Expand Down
5 changes: 4 additions & 1 deletion scripts/snapshot.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@ const featureFlags = [
'vitest',
'cypress',
'playwright',
'nightwatch'
'nightwatch',
'eslint',
'eslint-with-prettier'
]
const featureFlagsDenylist = [
['eslint', 'eslint-with-prettier'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to this file should be removed, as this is going to generate a lot of new snapshots (that's why they aren't generated at the moment).

Copy link
Contributor Author

@yoshi-pi yoshi-pi Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved eslint and eslint-with-prettier as separate features based on #460 (comment).

['cypress', 'playwright'],
['playwright', 'nightwatch'],
['cypress', 'nightwatch'],
Expand Down