feat: add plugin-markdown-chart #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
89fa630 to
b09f322
Compare
Pull Request Test Coverage Report for Build 15470406371Details
💛 - Coveralls |
|
@pengzhanbo I have some issues with katex in markmap, helps would be appreciated. |
I haven't used |
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
203dcb9 to
d4bad4a
Compare
✅ Deploy Preview for vuepress-ecosystem ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
62f68aa to
01b02ba
Compare
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
6bfd0bd to
1b9f741
Compare
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
f899860 to
dd1668b
Compare
|
This PR is now ready, it will replace chart features in md-enhance. |
Mister-Hope
force-pushed
the
plugin-markdown-chart
branch
from
2578362 to
fa7bad6
Compare
pengzhanbo
reviewed
Jun 6, 2025
Comment on lines
+28
to
+80
| dark: isDarkMode, | ||
| background: isDarkMode ? '#1e1e1e' : '#fff', | ||
|
|
||
| primaryColor: isDarkMode ? '#389d70' : '#4abf8a', | ||
| primaryBorderColor: isDarkMode ? '#389d70' : '#4abf8a', | ||
| primaryTextColor: isDarkMode ? '#fff' : '#000', | ||
|
|
||
| secondaryColor: '#ffb500', | ||
| secondaryBorderColor: isDarkMode ? '#fff' : '#000', | ||
| secondaryTextColor: isDarkMode ? '#ddd' : '#333', | ||
|
|
||
| tertiaryColor: isDarkMode ? '#282828' : '#efeef4', | ||
| tertiaryBorderColor: isDarkMode ? '#bbb' : '#242424', | ||
| tertiaryTextColor: isDarkMode ? '#ddd' : '#333', | ||
|
|
||
| // Note | ||
| noteBkgColor: isDarkMode ? '#f6d365' : '#fff5ad', | ||
| noteTextColor: '#242424', | ||
| noteBorderColor: isDarkMode ? '#f6d365' : '#333', | ||
|
|
||
| lineColor: isDarkMode ? '#d3d3d3' : '#333', | ||
| textColor: isDarkMode ? '#fff' : '#242424', | ||
|
|
||
| mainBkg: isDarkMode ? '#389d70' : '#4abf8a', | ||
| errorBkgColor: '#eb4d5d', | ||
| errorTextColor: '#fff', | ||
|
|
||
| // Flowchart | ||
| nodeBorder: isDarkMode ? '#389d70' : '#4abf8a', | ||
| nodeTextColor: isDarkMode ? '#fff' : '#242424', | ||
|
|
||
| // Sequence | ||
| signalTextColor: isDarkMode ? '#9e9e9e' : '#242424', | ||
|
|
||
| // Class | ||
| classText: '#fff', | ||
|
|
||
| // State | ||
| labelColor: '#fff', | ||
|
|
||
| attributeBackgroundColorEven: isDarkMode ? '#0d1117' : '#fff', | ||
| attributeBackgroundColorOdd: isDarkMode ? '#161b22' : '#f8f8f8', | ||
|
|
||
| // Colors | ||
| fillType0: isDarkMode ? '#cf1322' : '#f1636e', | ||
| fillType1: '#f39c12', | ||
| fillType2: '#2ecc71', | ||
| fillType3: '#fa541c', | ||
| fillType4: '#25a55b', | ||
| fillType5: '#13c2c2', | ||
| fillType6: '#096dd9', | ||
| fillType7: '#aa6fe9', | ||
| }) |
There was a problem hiding this comment.
We don't necessarily have to use the default theme's green benchmark color, as it doesn't look very appealing. Here are some adjustments I made in the plume theme for your reference; I think this looks much nicer.
defineMermaidConfig({
theme: 'default',
themeVariables: isDarkMode => ({
- primaryColor: isDarkMode ? '#389d70' : '#4abf8a',
- primaryBorderColor: isDarkMode ? '#389d70' : '#4abf8a',
- primaryTextColor: isDarkMode ? '#fff' : '#000',
+ primaryColor: isDarkMode ? '#c8abfa' : '#6f42c1',
+ primaryBorderColor: isDarkMode ? '#669' : '#99c',
+ primaryTextColor: isDarkMode ? '#c8abfa' : '#6f42c1',
- noteBkgColor: isDarkMode ? '#f6d365' : '#fff5ad',
+ noteBkgColor: isDarkMode ? '#c96' : '#fff5ad',
- noteBorderColor: isDarkMode ? '#f6d365' : '#333',
+ noteBorderColor: isDarkMode ? '#c86' : '#333',
- textColor: isDarkMode ? '#fff' : '#242424',
+ textColor: isDarkMode ? '#d3d3d3' : '#242424',
- mainBkg: isDarkMode ? '#389d70' : '#4abf8a',
+ mainBkg: isDarkMode ? 'rgb(159 122 234 / 0.16)' : 'rgb(159 122 234 / 0.14)',
- nodeBorder: isDarkMode ? '#389d70' : '#4abf8a',
- nodeTextColor: isDarkMode ? '#fff' : '#242424',
+ nodeBorder: isDarkMode ? '#669' : '#99c',
+ nodeTextColor: isDarkMode ? '#c8abfa' : '#6f42c1',
+ edgeLabelBackground: isDarkMode ? '#333' : '#ddd',
}),
+ class: {
+ hideEmptyMembersBox: true,
+ },
+ look: 'handDrawn',
})There was a problem hiding this comment.
There was a problem hiding this comment.
Let's merge it first and handle style improvements with a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.