drivers: wifi: options for application usage of Wi-Fi #84353
Conversation
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
anangl,
jaz1-nordic,
jukkar,
kl-cruz,
Kludentwo,
krish2718,
LucasTambor,
magp-nordic,
MaochenWang1,
marekmatej,
masz-nordic,
nika-nordic,
rlubos,
sachinthegreen and
sylvioalves
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
8e3e3de to
1f42b54
Compare
| @@ -539,7 +539,7 @@ config NXP_WIFI_SOFTAP_SUPPORT | |||
| bool "Wi-Fi SoftAP Support" | |||
| select NET_DHCPV4_SERVER | |||
| select WIFI_NM_HOSTAPD_AP if WIFI_NM_WPA_SUPPLICANT | |||
| default y | |||
| default y if WIFI_USAGE_MODE_AP || WIFI_USAGE_MODE_STA_AP | |||
There was a problem hiding this comment.
Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?
There was a problem hiding this comment.
Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?
This is changed by #87410 which disables AP mode by default.
There was a problem hiding this comment.
Great, I will try and keep an eye on that PR and update this one (and address the file conflicts) once it is in.
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
1f42b54 to
70b41da
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
This seems to have been fall through the cracks and become stale. @JordanYates is this still valid one, there did not seem to be too much resistance against it? |
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
70b41da to
b9747a4
Compare
Yes, the desire to set what WiFi mode the application wants from the application is still valid. |
| @@ -539,7 +539,7 @@ config NXP_WIFI_SOFTAP_SUPPORT | |||
| bool "Wi-Fi SoftAP Support" | |||
| select NET_DHCPV4_SERVER | |||
| select WIFI_NM_HOSTAPD_AP if WIFI_NM_WPA_SUPPLICANT | |||
| default y | |||
| default y if WIFI_USAGE_MODE_AP || WIFI_USAGE_MODE_STA_AP | |||
There was a problem hiding this comment.
Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?
This is changed by #87410 which disables AP mode by default.
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
b9747a4 to
b7c8498
Compare
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
b7c8498 to
b2ce37c
Compare
The `CONFIG_WIFI` symbol currently covers a number of different use-cases of Wi-Fi, primarily: * Wi-Fi AP (Broadcasting a network others can connect to) * Wi-Fi Station (Connecting to an AP + SSID scanning) * Wi-Fi AP + Station (Both the above) * Wi-Fi SSID scanning (SSID scanning only) Each of these application usages of Wi-Fi requires a different set of supporting options to operate correctly (`WPA_SUPP`, `NET_CONNECTION_MANAGER`, etc), and different opportunities for resource optimisation (System heap, buffer counts, etc). Currently, optimizing the Wi-Fi drivers depends on driver specific options, which can be challenging to find and are obviously not portable across different drivers. The addition of this choice allows applications to specify in a single Kconfig option which features of Wi-Fi they use, and enable individual Wi-Fi drivers to choose defaults based on those features. Signed-off-by: Jordan Yates <[email protected]>
Default the operation mode from the application requested Wi-Fi features, not the nRF70 part number. Signed-off-by: Jordan Yates <[email protected]>
Automatically enabled `ESP32_WIFI_AP_STA_MODE` if the application specifies it wants either feature. Signed-off-by: Jordan Yates <[email protected]>
Automatically enabled `NXP_WIFI_SOFTAP_SUPPORT` if the application specifies it wants AP support. Signed-off-by: Jordan Yates <[email protected]>
Reduce the number of config overrides needed for the various testcases by only enabling the options if needed in the first place. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
250122_wifi_modes
branch
from
b2ce37c to
6b57925
Compare
Add docs for `WIFI_USAGE_MODE` in the Wi-Fi section and release notes. Signed-off-by: Jordan Yates <[email protected]>
|
@jukkar @krish2718 this should be ready for review |
github-actions
bot
added
area: Networking
Release Notes
|
| @@ -58,10 +58,11 @@ config ESP32_WIFI_STA_AUTO_DHCPV4 | |||
|
|
|||
| config ESP32_WIFI_AP_STA_MODE | |||
| bool "Activates the Station/AP co-existence mode." | |||
| default y if WIFI_USAGE_MODE_STA_AP | |||
There was a problem hiding this comment.
I guess CONFIG_ESP32_WIFI_AP_STA_MODE=y should be replaced to CONFIG_WIFI_USAGE_MODE_STA_AP=y in samples/net/wifi/apsta_mode/socs/esp32_procpu.conf, right?
There was a problem hiding this comment.
And perhaps CONFIG_WIFI_USAGE_MODE_STA=y enabled by default in samples/net/wifi/shell/prf.conf?
I see now that default WIFI_USAGE_MODE_STA is enabled by default.
The
CONFIG_WIFIsymbol currently covers a number of different use-cases of Wi-Fi, primarily:Each of these application usages of Wi-Fi requires a different set of supporting options to operate correctly (
WPA_SUPP,NET_CONNECTION_MANAGER, etc), and different opportunities for resource optimization (System heap, buffer counts, etc).Currently, optimizing the Wi-Fi drivers depends on driver specific options, which can be challenging to find and are obviously not portable across different drivers.
The addition of this choice allows applications to specify in a single Kconfig option which features of Wi-Fi they use, and enable individual Wi-Fi drivers to choose defaults based on those features.