Add TCPC driver for FUSB307 #85831
Merged
Add TCPC driver for FUSB307 #85831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jfischer-no,
keith-zephyr,
sambhurst and
tmon-nordic
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
from
d3aca59 to
24959e8
Compare
Thank you for your review. I've created a new PR #86143 |
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
from
24959e8 to
d4fd4ff
Compare
Corrected macro definitions. Signed-off-by: Jianxiong Gu <[email protected]>
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
2 times, most recently
from
de601ac to
fa4feea
Compare
keith-zephyr
reviewed
Mar 5, 2025
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
from
fa4feea to
7a4ee45
Compare
keith-zephyr
previously approved these changes
Mar 12, 2025
tmon-nordic
previously approved these changes
Mar 14, 2025
jfischer-no
requested changes
Mar 14, 2025
drivers/usb_c/tcpc/tcpci.c
Outdated
|
|
||
| ret = tcpci_tcpm_get_status_register(bus, TCPC_REG_POWER_STATUS, ®); | ||
| if (ret == 0) { | ||
| *sinking = !!(reg & TCPC_REG_POWER_STATUS_SINKING_VBUS); |
There was a problem hiding this comment.
Should be just *sinking = reg & TCPC_REG_POWER_STATUS_SINKING_VBUS;, see C STD scalar value conversion to bool.
drivers/usb_c/tcpc/tcpci.c
Outdated
|
|
||
| ret = tcpci_tcpm_get_status_register(bus, TCPC_REG_POWER_STATUS, ®); | ||
| if (ret == 0) { | ||
| *sourcing = !!(reg & TCPC_REG_POWER_STATUS_SOURCING_VBUS); |
drivers/usb_c/tcpc/tcpci.c
Outdated
Comment on lines
625
to
628
| if (enable) { | ||
| /* Set Look4Connection command */ | ||
| return tcpci_write_reg8(bus, TCPC_REG_COMMAND, TCPC_REG_COMMAND_LOOK4CONNECTION); | ||
| } else { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
if (enable) {
/* Set Look4Connection command */
return tcpci_write_reg8(bus, TCPC_REG_COMMAND, TCPC_REG_COMMAND_LOOK4CONNECTION);
}
return 0;IIRC, there should be checkpatch warning for this kind of constructs.
drivers/usb_c/tcpc/fusb307.c
Outdated
| #define DT_DRV_COMPAT onnn_fusb307_tcpc | ||
| LOG_MODULE_REGISTER(tcpc_fusb307, CONFIG_USBC_LOG_LEVEL); | ||
|
|
||
| /** Data structure for device instances */ |
There was a problem hiding this comment.
Comment style must be /* */, it is documented.
Also, there is no need to comment obvious things like /* Data structure for device instances */, Delayable work, Boolean valu, State of CC1...
drivers/usb_c/tcpc/fusb307.c
Outdated
| VCONN_DISC_GPIO(node), \ | ||
| } | ||
|
|
||
| #define FUSB307_DRIVER_INIT(inst) \ |
There was a problem hiding this comment.
#define FUSB307_INSTANCE_DEFINE(inst)
drivers/usb_c/tcpc/fusb307.c
Outdated
| static struct fusb307_data drv_data_fusb307##inst = \ | ||
| FUSB307_DRIVER_DATA_INIT(DT_DRV_INST(inst)); \ | ||
| static struct fusb307_cfg drv_cfg_fusb307##inst = \ | ||
| FUSB307_DRIVER_CFG_INIT(DT_DRV_INST(inst)); \ |
There was a problem hiding this comment.
Just
static struct fusb307_cfg fusb307_cfg_##inst = {
.bus = I2C_DT_SPEC_GET(node), \
.alert_gpio = GPIO_DT_SPEC_GET(node, irq_gpios), \
.transmit_retries = DT_PROP(node, transmit_retries), \
VCONN_DISC_GPIO(node), \
};and the same for the data
Add generic functions that will be common to TCPCI compliant drivers. Signed-off-by: Jianxiong Gu <[email protected]>
Update set_snk_ctrl, set_src_ctrl, and set_low_power_mode to use the generic TCPCI function. Signed-off-by: Jianxiong Gu <[email protected]>
Updated set_drp_toggle to handle differences in TCPCI revisions. Added a macro for TCPCI revision and read it from the chip register during initialization. Signed-off-by: Jianxiong Gu <[email protected]>
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
from
7a4ee45 to
9fe0c8d
Compare
|
@jfischer-no thanks for the review. |
|
Sorry，I closed this PR by mistake. Reopen |
keith-zephyr
previously approved these changes
Mar 17, 2025
jfischer-no
reviewed
Mar 26, 2025
Add support for FUSB307. Signed-off-by: Jianxiong Gu <[email protected]>
Enable VBUS measurement before checking the VBUS level and disable it when unattached. Signed-off-by: Jianxiong Gu <[email protected]>
Add a build test to verify fusb307 driver builds correctly. Signed-off-by: Jianxiong Gu <[email protected]>
recalci
force-pushed
the
usbc_tcpc_fusb307
branch
from
9fe0c8d to
a5d4dbe
Compare
keith-zephyr
approved these changes
Mar 27, 2025
|
What is the status on this one? @sambhurst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the TCPC driver for the FUSB307 and includes several related fixes.