doc: binary blobs: remove TSC approval requirement #88875
Conversation
|
per action from the process working group meeting |
|
Query: can referrals to TSC still be made if reviewers have concerns about what is being added as a blob or the supporting usage of it? E.g. #80507 (comment) comment as per:
|
|
Should this be discussed in the TSC? |
I was thinking along similar lines when looking at the PR. @dleach02 could you please add some text that encapsulates that? |
|
Yes, I can add some text about escalation but it will likely reference our current guidance. This is just a normal PR with the normal rules. @henrikbrixandersen, yes, I think this ultimately needs to be put in front of TSC before final acceptance/rejection. This is the initial work to flush out via this review process and the Process working group. |
@nordicjm, completely agree. And for the reference you highlighted, I was made aware of this last night and had a direct conversation with the authors on what can or cannot be done. Thank you for catching and highlighting this. |
dleach02
force-pushed
the
blob_change
branch
2 times, most recently
from
7899062 to
3857381
Compare
|
You should also delete the binary blobs issue template as that is now obsolete once this PR is approved. |
Agreed, but I'm not sure where that actually exists. Is this something we do via a PR? |
https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/008_bin-blobs.md |
Remove the TSC approval requirements for binary blobs. Clarify in the language that the submitter and reviewers shall ensure that all binary blob requirements are being met before approval and integration into Zephyr. Signed-off-by: David Leach <[email protected]>
|
@carlescufi we discussed in process wg having the action that detects module.yml change to add a blob cause a flag to be set on the PR. Is this doable? |
There was a problem hiding this comment.
Looks good to me. @carlescufi is it possible to improve the tooling to detect blobs on PRs?
On it. |
|
@dleach02 @keith-zephyr to be clear, you want a label added to the PR when one or more new binary blobs are added, or also when existing ones are updated to a new revision or URL? |
Probably good to flag the PR for new blobs and changes to existing blobs. We don't want a license change or some other violation of the blob policy to slip by when updating an existing blob. |
|
DNM until the manifest check is ready |
|
I suspect we need to take this PR to a TSC vote. Because this change is taking away something that was part of the TSC responsibility if feels like we should give the TSC body a chance to approve this. Thoughts? |
I agree. |
|
PR for the manifest action update: #90379 |
Merged, no blockers anymore. |
Remove the TSC approval requirements for binary blobs. Clarify in the language that the submitter and reviewers shall ensure that all binary blob requirements are being met before approval and integration into Zephyr.