drivers: sensor: ad2s1210: implementation of driver #88919
Conversation
github-actions
bot
added
area: Sensors
github-actions
bot
requested review from
asemjonovs,
avisconti,
galak,
jeppenodgaard,
MaureenHelm,
microbuilder,
ozersa,
teburd,
tristan-google,
ttmut,
ubieda,
yasinustunerg and
yperess
nono313
force-pushed
the
implement-ad2s1210-driver
branch
7 times, most recently
from
f618bbe to
5e3204a
Compare
nono313
changed the title
There was a problem hiding this comment.
Thank you for opening this PR!
There's comments that are redundant other are fine. See https://kernel.org/doc/html/latest/process/coding-style.html#commenting
nono313
force-pushed
the
implement-ad2s1210-driver
branch
2 times, most recently
from
8a07504 to
7deabf2
Compare
nono313
changed the title
|
|
||
| compatible: "adi,ad2s1210" | ||
|
|
||
| include: spi-device.yaml |
There was a problem hiding this comment.
| include: spi-device.yaml | |
| include: [spi-device.yaml, sensor-device.yaml] |
| .have_resolution_pins = (DT_INST_NODE_HAS_PROP(i, resolution_gpios)), \ | ||
| }; \ | ||
| \ | ||
| DEVICE_DT_INST_DEFINE(i, ad2s1210_init, NULL, &ad2s1210_data_##i, &ad2s1210_config_##i, \ |
There was a problem hiding this comment.
Use SENSOR_DEVICE_DT_INST_DEFINE
There was a problem hiding this comment.
Thanks, I have updated the INST_DEFINE macro
|
|
||
| assigned-resolution-bits: | ||
| type: int | ||
| default: 16 |
There was a problem hiding this comment.
Need to explain in the description why the default value was selected
https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#dt-bindings-default-rules
There was a problem hiding this comment.
Looking at the datasheet, it seems default at power up (without configuration) is 12-bits so I am changing to 12 bits and adding explanation in description.
nono313
force-pushed
the
implement-ad2s1210-driver
branch
from
7deabf2 to
f4cf010
Compare
|
Could you update the title of this commit drivers: sensor: ad2s1210: start implementation of driver. Something like |
implement driver for ad2s1210 resolver Signed-off-by: Nathan Olff <[email protected]>
add ad2s1210 to build_all test in spi.dtsi Signed-off-by: Nathan Olff <[email protected]>
nono313
force-pushed
the
implement-ad2s1210-driver
branch
from
f4cf010 to
bdcf517
Compare
|
|
@jeppenodgaard can you take another look? |
Implement driver for ad2s1210 rotational resolver
Based on datasheet here : https://www.analog.com/media/en/technical-documentation/data-sheets/ad2s1210.pdf