riscv: use reg-names in machine timer driver and DTS #89847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the riscv_machine_timer driver to resolve MTIME and MTIMECMP register addresses by their `reg-names` instead of relying on index order. This improves clarity and robustness in DTS bindings, and is a prerequisite for handling cases where not both MTIME and MTIMECMP registers are present or accessible. Signed-off-by: Chen Xingyu <[email protected]>
This commit updates all relevant device tree source files using the riscv,machine-timer binding to explicitly define `reg-names` for the MTIME and MTIMECMP registers. This change ensures compatibility with the updated riscv_machine_timer driver, which now relies on `reg-names` to resolve register addresses instead of using fixed index positions. Signed-off-by: Chen Xingyu <[email protected]>
github-actions
bot
added
area: RISCV
github-actions
bot
requested review from
andyross,
cameled,
carlocaione,
edersondisouza,
jimmyzhe,
katsuster,
kevinwang821020,
kgugala,
mgielda,
nandojve,
soburi,
teburd and
tgorochowik
nandojve
previously approved these changes
May 12, 2025
7 tasks
VynDragon
previously approved these changes
May 12, 2025
jimmyzhe
previously approved these changes
May 13, 2025
soburi
previously approved these changes
May 13, 2025
|
It might be a good idea to mention this change in the migration guide. For users with an out of tree board and soc. |
@maass-hamburg Good idea! @VynDragon I noticed #84175 wasn’t mentioned in the 4.1 migration guide. Since this change builds on that — including the switch from |
Clarify the changes introduced in machine timer bindings: * Several legacy compatibles (e.g. andestech,machine-timer, neorv32-machine-timer, etc.) have been unified under riscv,machine-timer. * MTIME and MTIMECMP addresses must now be specified explicitly using the reg and reg-names properties. * The reg-names property is now required and must match the reg entries one-to-one. Signed-off-by: Chen Xingyu <[email protected]>
xingrz
requested review from
soburi,
VynDragon,
jimmyzhe,
nandojve and
maass-hamburg
and removed request for
jimmyzhe
|
jimmyzhe
approved these changes
May 14, 2025
soburi
approved these changes
May 14, 2025
nandojve
approved these changes
May 14, 2025
maass-hamburg
approved these changes
May 14, 2025
fkokosinski
approved these changes
May 14, 2025
andyross
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #84175, addresses of the MTIME and MTIMECMP registers are defined in DTS and retrieved using the
DT_INST_REG_ADDR_BY_IDXmacro.This PR refines that approach by switching to
DT_INST_REG_ADDR_BY_NAME, using thereg-namesproperty to explicitly identify the MTIME and MTIMECMP registers. This improves readability and avoids reliance on index ordering, especially in cases where one of the registers may be absent or implemented differently.This PR includes:
riscv,machine-timerdriver to usereg-namesinstead of register index.reg-names = "mtime", "mtimecmp"to all relevant machine timer nodes.This enhancement enables better support for platforms with nonstandard timer register layouts and serves as a prerequisite for #69594.