Bluetooth: RFCOMM: Fix CR bit in DISC frame #89930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: XS
github-actions
bot
requested review from
gzh-terry,
jhedberg,
lylezhu2012,
makeshi and
MarkWangChinese
jhedberg
approved these changes
May 14, 2025
jhedberg
added
the
Trivial
ubieda
approved these changes
May 14, 2025
The CR bit in DISC frames should be set as a command rather than a response. This patch fixes the rfcomm_send_disc function to correctly use BT_RFCOMM_CMD_CR instead of BT_RFCOMM_RESP_CR when setting the CR bit in the address field of DISC frames. Signed-off-by: Jiawei Yang <[email protected]>
jerryyang35
force-pushed
the
fix_rfcomm_disc_rc_err
branch
from
b99744b to
c240d27
Compare
|
This was referenced May 19, 2025
|
Since this PR has been approved 2w ago and it may block certain PTS cases. |
lylezhu2012
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CR bit in DISC frames should be set as a command rather than a response.
This patch fixes the rfcomm_send_disc function to correctly use BT_RFCOMM_CMD_CR
instead of BT_RFCOMM_RESP_CR when setting the CR bit in the address field of
DISC frames.
This issue causes PTS fail