gnss: Add UBX F9P driver #90027
gnss: Add UBX F9P driver #90027
Conversation
|
@bperseghetti @PetervdPerk-NXP would you mind providing some feedback on the UBX config-set for F9P (last two patches)? I'd like to know if I should be pulling some more levers. EDIT: RTK support will come on a follow-on PR. |
ubieda
force-pushed
the
gnss/ubx-f9-driver
branch
from
471354d to
778cf29
Compare
ubieda
force-pushed
the
gnss/ubx-f9-driver
branch
2 times, most recently
from
caeb352 to
df473cd
Compare
github-actions
bot
requested review from
bjarki-andreasen,
fabiobaltieri and
tomi-font
| UBX_FRAME_DEFINE(nav_fix_mode_auto, | ||
| UBX_FRAME_CFG_VAL_SET_U8_INITIALIZER(UBX_KEY_NAV_CFG_FIX_MODE, UBX_FIX_MODE_AUTO)); |
There was a problem hiding this comment.
Users might want an easy way to force this to 3D only outside of setting the dyn model.
There was a problem hiding this comment.
This could be exposed through a device-tree property, however I'd suggest considering this (and the filtering config) as out of scope for the current PR.
There was a problem hiding this comment.
Overall looks great to me!
My provided inline comments are for suggestions of potential future expansion and in no way need addressing for this particular PR. Also to those comments I might add that we could in the future also maybe implement some more of the nav input filters from Page 24.
Thanks for this great contribution!
ubieda
force-pushed
the
gnss/ubx-f9-driver
branch
from
df473cd to
d6883e0
Compare
|
CI failures are unrelated. Other occurrences: |
|
Change requests should be addressed. Feel free to take another look @bjarki-andreasen @bperseghetti |
Basic support: initialization for sending/handling UBX messages and run-time navigation configurability through GNSS API. Signed-off-by: Luis Ubieda <[email protected]>
For build-time validation. Signed-off-by: Luis Ubieda <[email protected]>
ubieda
force-pushed
the
gnss/ubx-f9-driver
branch
from
d6883e0 to
c9f391e
Compare
|
Just rebased given the unrelated failure was fixed on main-line #90971 |
|
Description
Introducing basic support: Initialization and sending/handling UBX commands through modem_ubx.
Also supports run-time configurability through GNSS APIs and default build-time fix-rate through device-tree binding.
Testing
Run GNSS sample with F9P GNSS module (on
vmu_rt1170/mimxrt1176/cm7) and verify navigation data & satellites data is output, as well as GNSS APIs work (e.g: addgnss_set_fix_rate()andgnss_set_navigation_mode()and verify it's effective.