drivers: i2c: Add support for clock stretching in the i2c-gpio module. #90076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas-archembedded
force-pushed
the
dev/add_i2c_clock_stretching
branch
from
21f73b6 to
182d0f0
Compare
teburd
reviewed
May 16, 2025
bas-archembedded
force-pushed
the
dev/add_i2c_clock_stretching
branch
from
182d0f0 to
5426ec9
Compare
bas-archembedded
force-pushed
the
dev/add_i2c_clock_stretching
branch
from
5426ec9 to
77a922f
Compare
teburd
previously approved these changes
May 20, 2025
jeetarora72
reviewed
May 28, 2025
drivers/i2c/i2c_bitbang.c
Outdated
| @@ -60,6 +64,8 @@ int i2c_bitbang_configure(struct i2c_bitbang *context, uint32_t dev_config) | |||
| return -ENOTSUP; | |||
| } | |||
|
|
|||
| context->delays[T_CLK_STR] = | |||
| MS_TO_SYS_CLOCK_HW_CYCLES(CONFIG_I2C_GPIO_CLOCK_STRETCHING_TIMEOUT_MS); | |||
There was a problem hiding this comment.
Shouldn't this also be guarded by CONFIG_I2C_GPIO_CLOCK_STRETCHING? Do you have a different perspective on this?
There was a problem hiding this comment.
This is now obsolete since it was transformed to WAIT_US() macro.
drivers/i2c/i2c_bitbang.h
Outdated
| @@ -28,7 +32,7 @@ struct i2c_bitbang_io { | |||
| struct i2c_bitbang { | |||
| const struct i2c_bitbang_io *io; | |||
| void *io_context; | |||
| uint32_t delays[2]; | |||
| uint32_t delays[3]; | |||
There was a problem hiding this comment.
can you define ARRAY_SIZE as a macro that sets the size to 3 when clock stretching is enabled, and to 2 otherwise
For example :
#define I2C_GPIO_SIZE 2
#define I2C_GPIO_CLK_STR_SIZE 3
##ifdef CONFIG_I2C_GPIO_CLOCK_STRETCHING
#define ARRAY_SIZE I2C_GPIO_CLK_STR_SIZE
else
#define ARRAY_SIZE I2C_GPIO_SIZE
#endif
pdgendt
previously requested changes
May 28, 2025
Some I2C peripherals like TI charger or gauge chips need support for I2C clock stretching. This patch includes that and makes these modules usable with I2C emulation over GPIO. Signed-off-by: Bas van Loon <[email protected]>
bas-archembedded
force-pushed
the
dev/add_i2c_clock_stretching
branch
from
77a922f to
5630707
Compare
|
teburd
approved these changes
May 28, 2025
nashif
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some I2C peripherals like TI charger or gauge chips need support for I2C clock stretching. This patch includes that and makes these modules usable with I2C emulation over GPIO.