Skip to content

MAINTAINERS: Add video maintainer #90083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

ngphibang
Copy link
Collaborator

@ngphibang ngphibang commented May 16, 2025

The video section has evolved but lacks maintainers, which affects the process of merging video-related PRs. As initially discussed by @josuah and @avolmat-st, add myself "ngphibang" as maintainer for video drivers.

It would be better to have more maintainers to consolidate the review process.

@loicpoulain @josuah @avolmat-st

@@ -2176,11 +2176,12 @@ Release Notes:
- "area: Timer"

"Drivers: Video":
status: odd fixes
status: maintained
maintainers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, video subsystem is clearly active these days. I think It would make sense to add everyone below under maintainers, with them as reviewer of this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @loicpoulain, I don't know exactly what the process is for reviewing but it's fine to me to follow.
It's also fine to me to add other people who want to step up as video maintainers in this same PR if needed (but I am not sure if it's the right way or it should be done independently).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am volonter as well as maintainers if that is ok. If ok with that way you can also add me to the list.

Copy link
Collaborator

@josuah josuah May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am willing to join the maintenance as well:

  • if it even helps to have 4 maintainers rather than 2,
  • if occasional misses to the "2 day before reviews" are acceptable, as I missed that rule for instance today as I just came back from a conference. I am around a PR 24h max usually.

Copy link
Collaborator

@josuah josuah May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open separate PRs for @avolmat-st, @loicpoulain and @josuah. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule is simply that a PR cannot be merged until it has been approved by the right people AND has been in review for a minimum of 2 business days.

Good to know thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes things easier that I stay within the collaborators section as currently.

Copy link
Collaborator Author

@ngphibang ngphibang May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have (at least) two maintainters. I propose to add josuah to the list (I didn't know that we can add multiple people in the same PR) and wish to retain my candidature and motivation too.

Copy link
Collaborator

@josuah josuah May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loicpoulain did you also want being listed in maintainers? There are typically 1~2 maintainers per area, but ~10 areas have 3.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josuah yes, I would like to be involved as maintainer for that video subsystem/framework.

avolmat-st
avolmat-st previously approved these changes May 18, 2025
josuah
josuah previously approved these changes May 18, 2025
dleach02
dleach02 previously approved these changes May 18, 2025
Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video subsystem has be very active for a good period of time. All of these collaborators have been working well together to move things along. They have also been growing this sub-community which is very helpful.

Also, and most importantly for me, having a maintainer means the dang bot will stop assigning these PRs to me ;-)...

But seriously, keep working together as you have been. You can have more than one maintainer if it helps ensure proper coverage of assignees for PRs.

Add Josuah Demangeon "josuah" and Phi Bang Nguyen "ngphibang"
as maintainers for video drivers.

Signed-off-by: Phi Bang Nguyen <[email protected]>
@ngphibang ngphibang dismissed stale reviews from dleach02, josuah, and avolmat-st via 5466a2a May 20, 2025 12:28
@ngphibang ngphibang force-pushed the video_maintainers branch from 8350a80 to 5466a2a Compare May 20, 2025 12:28
Copy link

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as-is and reflects current commitment and contributions from the individuals concerned by this PR IMO. I would not recommend adding more maintainers at this point.

@kartben
Copy link
Collaborator

kartben commented May 27, 2025

ping @nashif @MaureenHelm -- this is good to go I think

@kartben kartben merged commit fadb9c7 into zephyrproject-rtos:main May 27, 2025
21 checks passed
@ngphibang ngphibang deleted the video_maintainers branch June 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants