driver: flash: Add Set/ Get write protect function #90150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
de-nordic,
JasonLin-RealTek and
rghaddab
keith-zephyr
requested changes
May 21, 2025
| @@ -427,20 +427,44 @@ static int flash_read_sr2(const struct device *dev, uint8_t *val) | |||
| } | |||
| #endif | |||
|
|
|||
| #ifdef CONFIG_FLASH_EX_OP_ENABLED | |||
| #define SPIC_BASE 0x40010200ul | |||
There was a problem hiding this comment.
This base address is already captured by the driver config structure.
| #define SPIC_BASE 0x40010200ul | ||
| static int flash_set_wp(const struct device *dev, uint8_t *val, uint8_t cnt) | ||
| { | ||
| volatile uint32_t *reg = (volatile uint32_t *)(SPIC_BASE + 0x110u); |
There was a problem hiding this comment.
You need to define register 0x110 in the struct reg_spic_reg structure.
Suggested change
| volatile uint32_t *reg = (volatile uint32_t *)(SPIC_BASE + 0x110u); | |
| const struct flash_rts5912_dev_config *config = dev->config; | |
| volatile struct reg_spic_reg *spic_reg = config->regs; |
|
|
||
| static int flash_get_wp(const struct device *dev, uint8_t *val) | ||
| { | ||
| volatile uint32_t *reg = (volatile uint32_t *)(SPIC_BASE + 0x110u); |
There was a problem hiding this comment.
Same here - use struct reg_spic_reg to access the register at offset 0x110.
benson0715
force-pushed
the
main
branch
3 times, most recently
from
7209bcd to
f1affb5
Compare
| @@ -427,20 +427,44 @@ static int flash_read_sr2(const struct device *dev, uint8_t *val) | |||
| } | |||
| #endif | |||
|
|
|||
| #ifdef CONFIG_FLASH_EX_OP_ENABLED | |||
| static int flash_set_wp(const struct device *dev, uint8_t *val, uint8_t cnt) | |||
There was a problem hiding this comment.
cnt parameter is not used.
Add Set_WP function to set SPI flash WP line to low Add Get_WP function to obtain status of the SPI flash WP line Signed-off-by: Benson Huang <[email protected]>
|
keith-zephyr
approved these changes
May 27, 2025
JasonLin-RealTek
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Set_WP function to set SPI flash WP line to low
Add Get_WP function to obtain status of the SPI flash WP line