west: blobs: fetch exit immediately on HTTP error #90231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahp
force-pushed
the
noahp/west-blobs-fetch-http-error-exit
branch
from
cc078c8 to
8a50fb9
Compare
pdgendt
reviewed
May 21, 2025
|
You need to squash your commits into a single one, and force push. |
noahp
force-pushed
the
noahp/west-blobs-fetch-http-error-exit
branch
from
cb4dda6 to
85eee4b
Compare
All set, thank you! |
noahp
force-pushed
the
noahp/west-blobs-fetch-http-error-exit
branch
from
85eee4b to
cae0059
Compare
If an HTTP error occurs during `west blobs fetch`, the response was written to a file (even if the response body is empty), and then the checksum validation fails, which can be somewhat confusing. Add an immediate error message and exit-with-error-code when the HTTP request fails. Tested by modify a blob manifest to have an invalid URL: ```bash # test with invalid URL ❯ west blobs fetch nrf_wifi Fetching blob nrf_wifi: .../wifi_fw_bins/default/nrf70.bin ERROR: HTTP error occurred: 404 Client Error: Not Found for url: ... # test with networking disabled ❯ west blobs fetch nrf_wifi Fetching blob nrf_wifi: .../wifi_fw_bins/default/nrf70.bin ERROR: An error occurred: HTTPSConnectionPool(host='git.... \ Max retries exceeded with url: \ .../zzzz/nrf_wifi/bin/zephyr/default/nrf70.bin ... ``` Signed-off-by: Noah Pendleton <[email protected]>
noahp
force-pushed
the
noahp/west-blobs-fetch-http-error-exit
branch
from
cae0059 to
5e0a531
Compare
|
pdgendt
approved these changes
May 22, 2025
kartben
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an HTTP error occurs during
west blobs fetch, the response was written to a file (even if the response body is empty), and then the checksum validation fails, which can be somewhat confusing.Add an immediate error message and exit-with-error-code when the HTTP request fails.
Tested by modify a blob manifest to have an invalid URL: