boards: st: fix boards DTS files coding style issues #90312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
github-actions
bot
requested review from
asm5878,
benothmn-st,
djiatsaf-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
HoZHel,
marwaiehm-st and
mathieuchopstm
|
I've split the changes into 1 commit per SoC family but I could squash the whole into a signle commit (at least for the coding style issues fixes) if one prefers. |
nordicjm
previously approved these changes
May 22, 2025
| @@ -97,7 +106,7 @@ | |||
|
|
|||
| stm32_lp_tick_source: &lptim1 { | |||
| clocks = <&rcc STM32_CLOCK_BUS_APB1 0x80000000>, | |||
| <&rcc STM32_SRC_LSI LPTIM1_SEL(1)>; | |||
| <&rcc STM32_SRC_LSI LPTIM1_SEL(1)>; | |||
There was a problem hiding this comment.
can use space after tab to align with line above (optional)
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. By the way, also correct indentation in node stm32_lp_tick_source of b_g474e_dpow1.dts. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Indent with tabs. - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. Also remove a few spurious space characters. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Don’t insert empty lines before a dedenting };. - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix board DTS coding style issues to prevent they spread when a new board is introduced and used this DTS as example start point. Issues addressed from Zephyr devicetree style guidelines [1]: - Insert a single empty line to separate nodes at the same hierarchy level. No functional change. Link: https://docs.zephyrproject.org/latest/contribute/style/devicetree.html [1] Signed-off-by: Etienne Carriere <[email protected]>
Fix end offset value in inline comment of the internal partition node. Signed-off-by: Etienne Carriere <[email protected]>
|
Thanks for the review comments. I've addressed them. |
|
Nitpicking: I think the commit messages header lines should end with |
erwango
approved these changes
May 22, 2025
|
gautierg-st
approved these changes
May 22, 2025
JarmouniA
approved these changes
May 22, 2025
mathieuchopstm
approved these changes
May 22, 2025
benothmn-st
approved these changes
May 22, 2025
HoZHel
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few coding style issues in ST board DTS files to prevent they spread when a new board is introduced and used this DTS as example start point.
Issues addressed from Zephyr devicetree style guidelines [1]:
- Indent with tabs.
- Don’t insert empty lines before a dedenting };.
- Insert a single empty line to separate nodes at the same hierarchy level.
By the way, fix also an inline comment (stm32f0_disco)
and a use of label reference (nucleo_f334r8).No functional change.
[1] https://docs.zephyrproject.org/latest/contribute/style/devicetree.html