drivers: gpio: davinci: fix gpio output #90316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently to set/clear the pins, we do a logical OR of the value with the existing values in set/clear registers. However, reading these registers always returns the value in out_data register. This is undesirable as it can cause unnecessary complications. Consider the following scenario: We need to set PIN 0: set_data |= BIT(0) We need to clear PIN 1: clr_data |= BIT(1) The latter would also clear the 0th bit due to the aforementioned behaviour. This patch fixes this by writing the mask directly without ORing. Signed-off-by: Amneesh Singh <[email protected]>
|
github-actions
bot
added
platform: TI K3
github-actions
bot
requested review from
dnltz,
glneo,
gramsay0,
henrikbrixandersen,
mnkp and
vaishnavachath
|
CC: @Ayush1325 |
glneo
approved these changes
May 22, 2025
Ayush1325
approved these changes
May 22, 2025
vaishnavachath
approved these changes
May 23, 2025
dnltz
approved these changes
May 23, 2025
gramsay0
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to set/clear the pins, we do a logical OR of the value with the existing values in set/clear registers. However, reading these registers always returns the value in out_data register. This is undesirable as it can cause unnecessary complications. Consider the following scenario:
We need to set PIN 0:
set_data |= BIT(0)
We need to clear PIN 1:
clr_data |= BIT(1)
The latter would also clear the 0th bit due to the aforementioned behaviour.
This patch fixes this by writing the mask directly without ORing.