-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Bluetooth: Classic: Fix LTK cannot be derived issue #90369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Classic: Fix LTK cannot be derived issue #90369
Conversation
The LTK cannot be derived by LK when LK is not weaker than the old LTK. Improve the function `smp_br_pairing_allowed()` to avoid the LTK be overwrote when old LTK has MITM protection but new LK has not MITM protection. Signed-off-by: Lyle Zhu <[email protected]>
|
@alwa-nordic another case where a classic-specific change is not assigned any classic collaborators. @lylezhu2012 we discussed in the BT meeting yesterday that there are many files (such as this) that isn't under the We discussed 2 options:
Currently the documentation states that the assignee (e.g. @alwa-nordic ) is responsible for driving the PR to a mergable state (which includes assigning the right reviewers), but that is a manual process I think is too much to handle for BT. |
@Thalley Understood. Thanks a lot.
Do I need to do this now? |
I'll leave that up to you. It will ensure that people interested in classic will get the changes and automatically added as reviewers, but it will also add them as reviewers to a lot more PRs. |
The LTK cannot be derived by LK when LK is not weaker than the old LTK.
Improve the function
smp_br_pairing_allowed()
to avoid the LTK be overwrote when old LTK has MITM protection but new LK has not MITM protection.