Skip to content

Bluetooth: Classic: Fix LTK cannot be derived issue #90369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lylezhu2012
Copy link
Collaborator

The LTK cannot be derived by LK when LK is not weaker than the old LTK.

Improve the function smp_br_pairing_allowed() to avoid the LTK be overwrote when old LTK has MITM protection but new LK has not MITM protection.

The LTK cannot be derived by LK when LK is not weaker than the old LTK.

Improve the function `smp_br_pairing_allowed()` to avoid the LTK be
overwrote when old LTK has MITM protection but new LK has not MITM
protection.

Signed-off-by: Lyle Zhu <[email protected]>
@github-actions github-actions bot added area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) labels May 23, 2025
@lylezhu2012 lylezhu2012 deleted the classic_fix_key_drive_issue branch May 23, 2025 03:56
@lylezhu2012 lylezhu2012 restored the classic_fix_key_drive_issue branch May 23, 2025 03:56
@lylezhu2012 lylezhu2012 reopened this May 23, 2025
Copy link

@Thalley
Copy link
Collaborator

Thalley commented May 23, 2025

@alwa-nordic another case where a classic-specific change is not assigned any classic collaborators.

@lylezhu2012 we discussed in the BT meeting yesterday that there are many files (such as this) that isn't under the Bluetooth Classic: area in MAINTAINERS.yml, so they won't get the appropriate reviewers for Classic only changes.

We discussed 2 options:

  1. Add shared files between LE and Classic to the classic area (such as conn.c, smp.c, l2cap.c, etc).
  2. Try to modify the CI system to assign people to reviewer based on labels, i.e. adding the BT classic label here could possibly add all classic collaborators.

Currently the documentation states that the assignee (e.g. @alwa-nordic ) is responsible for driving the PR to a mergable state (which includes assigning the right reviewers), but that is a manual process I think is too much to handle for BT.

@Thalley Thalley removed their request for review May 23, 2025 07:33
@lylezhu2012
Copy link
Collaborator Author

lylezhu2012 commented May 26, 2025

@Thalley Understood. Thanks a lot.

  1. Add shared files between LE and Classic to the classic area (such as conn.c, smp.c, l2cap.c, etc).

Do I need to do this now?

@Thalley
Copy link
Collaborator

Thalley commented May 26, 2025

@Thalley Understood. Thanks a lot.

  1. Add shared files between LE and Classic to the classic area (such as conn.c, smp.c, l2cap.c, etc).

Do I need to do this now?

I'll leave that up to you. It will ensure that people interested in classic will get the changes and automatically added as reviewers, but it will also add them as reviewers to a lot more PRs.

@alwa-nordic alwa-nordic added the area: Bluetooth Classic Bluetooth Classic (BR/EDR) label May 27, 2025
@kartben kartben merged commit 5f7fbb6 into zephyrproject-rtos:main May 28, 2025
51 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Classic Bluetooth Classic (BR/EDR) area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants